Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/AllConfig.php

Summary

Maintainability
B
6 hrs
Test Coverage

AllConfig has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class AllConfig implements IConfig {
    /** @var SystemConfig */
    private $systemConfig;

    /** @var IDBConnection */
Severity: Minor
Found in lib/private/AllConfig.php - About 2 hrs to fix

    Method getUsersForUserValue has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function getUsersForUserValue($appName, $key, $value) {
        // TODO - FIXME
        $this->fixDIInit();

        $queryBuilder = $this->connection->getQueryBuilder();
    Severity: Minor
    Found in lib/private/AllConfig.php - About 1 hr to fix

      Method setUserValue has 36 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function setUserValue($userId, $appName, $key, $value, $preCondition = null) {
        if (!\is_int($value) && !\is_float($value) && !\is_string($value)) {
            throw new \UnexpectedValueException('Only integers, floats and strings are allowed as value');
        }
      Severity: Minor
      Found in lib/private/AllConfig.php - About 1 hr to fix

        Method setUserValue has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function setUserValue($userId, $appName, $key, $value, $preCondition = null) {
        Severity: Minor
        Found in lib/private/AllConfig.php - About 35 mins to fix

          Function setUserValue has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              public function setUserValue($userId, $appName, $key, $value, $preCondition = null) {
        if (!\is_int($value) && !\is_float($value) && !\is_string($value)) {
            throw new \UnexpectedValueException('Only integers, floats and strings are allowed as value');
        }
          Severity: Minor
          Found in lib/private/AllConfig.php - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status