owncloud/core

View on GitHub
lib/private/AppFramework/DependencyInjection/DIContainer.php

Summary

Maintainability
F
5 days
Test Coverage

Method __construct has 262 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($appName, $urlParams = []) {
        parent::__construct();
        $this['AppName'] = $appName;
        $this['urlParams'] = $urlParams;

Severity: Major
Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 1 day to fix

    File DIContainer.php has 333 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * @author Bernhard Posselt <dev@bernhard-posselt.com>
     * @author Christoph Wurst <christoph@owncloud.com>
     * @author Joas Schilling <coding@schilljs.com>
    Severity: Minor
    Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 4 hrs to fix

      Avoid too many return statements within this method.
      Open

                  return $this->getServer()->getCommentsManager();
      Severity: Major
      Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $this->getServer()->getActivityManager();
        Severity: Major
        Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return $this->getServer()->getCache();
          Severity: Major
          Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return $this->getServer()->getMemCacheFactory();
            Severity: Major
            Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $this->getServer()->getL10N($c->query('AppName'));
              Severity: Major
              Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return $this->getServer()->getRouter();
                Severity: Major
                Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return $this->getServer()->getUserSession();
                  Severity: Major
                  Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return $this->getServer()->getEventDispatcher();
                    Severity: Major
                    Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return new CORSMiddleware(
                                      $c['Request'],
                                      $c['ControllerMethodReflector'],
                                      $c['OCP\IUserSession'],
                                      $c['OCP\IConfig']
                      Severity: Major
                      Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return $this->getServer()->getRootFolder();
                        Severity: Major
                        Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return $this->getServer()->getGroupManager();
                          Severity: Major
                          Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return $this->getServer()->getShareManager();
                            Severity: Major
                            Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return $this->getServer()->getContentSecurityPolicyManager();
                              Severity: Major
                              Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return $dispatcher;
                                Severity: Major
                                Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return $this->getServer()->getCredentialsManager();
                                  Severity: Major
                                  Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return $this->getServer()->getSearch();
                                    Severity: Major
                                    Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                  return $this->getServer()->getSystemTagObjectMapper();
                                      Severity: Major
                                      Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                    return $this->getServer()->getAvatarManager();
                                        Severity: Major
                                        Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                      return $this->getServer()->getMountProviderCollection();
                                          Severity: Major
                                          Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                        return $this->getServer()->getDb();
                                            Severity: Major
                                            Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                          return $this->getServer()->getMimeTypeDetector();
                                              Severity: Major
                                              Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                            return $this->getServer()->getHTTPClientService();
                                                Severity: Major
                                                Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                              return $this->getServer()->getNavigationManager();
                                                  Severity: Major
                                                  Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                return $this->getServer()->getCrypto();
                                                    Severity: Major
                                                    Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                                  return $this->getServer()->getRequest();
                                                      Severity: Major
                                                      Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                    return $this->getServer()->getSecureRandom();
                                                        Severity: Major
                                                        Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                      return $this->getServer()->getSystemTagManager();
                                                          Severity: Major
                                                          Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                            Avoid too many return statements within this method.
                                                            Open

                                                                        return $this->getServer()->getHasher();
                                                            Severity: Major
                                                            Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                              Avoid too many return statements within this method.
                                                              Open

                                                                          return $c->query('ServerContainer')->getWebRoot();
                                                              Severity: Major
                                                              Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                Avoid too many return statements within this method.
                                                                Open

                                                                            return $this->getServer()->getSearch();
                                                                Severity: Major
                                                                Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                  Avoid too many return statements within this method.
                                                                  Open

                                                                              return $this->getServer()->getDateTimeZone();
                                                                  Severity: Major
                                                                  Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                    Avoid too many return statements within this method.
                                                                    Open

                                                                                return $this->getServer()->getQueryLogger();
                                                                    Severity: Major
                                                                    Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                      Avoid too many return statements within this method.
                                                                      Open

                                                                                  return $this->getServer()->getMailer();
                                                                      Severity: Major
                                                                      Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                        Avoid too many return statements within this method.
                                                                        Open

                                                                                    return $this->getServer()->getPreviewManager();
                                                                        Severity: Major
                                                                        Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                          Avoid too many return statements within this method.
                                                                          Open

                                                                                      return $c->query('OCP\\IUserSession')->getSession()->get('user_id');
                                                                          Severity: Major
                                                                          Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                            Avoid too many return statements within this method.
                                                                            Open

                                                                                        return new API();
                                                                            Severity: Major
                                                                            Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                              Avoid too many return statements within this method.
                                                                              Open

                                                                                          return new Dispatcher(
                                                                                              $c['Protocol'],
                                                                                              $c['MiddlewareDispatcher'],
                                                                                              $c['ControllerMethodReflector'],
                                                                                              $c['Request']
                                                                              Severity: Major
                                                                              Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                Avoid too many return statements within this method.
                                                                                Open

                                                                                            return $this->getServer()->getJobList();
                                                                                Severity: Major
                                                                                Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                  Avoid too many return statements within this method.
                                                                                  Open

                                                                                              return $this->getServer()->getTempManager();
                                                                                  Severity: Major
                                                                                  Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                    Avoid too many return statements within this method.
                                                                                    Open

                                                                                                return $this->getServer();
                                                                                    Severity: Major
                                                                                    Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                      Avoid too many return statements within this method.
                                                                                      Open

                                                                                                  return $this->getServer()->getContactsManager();
                                                                                      Severity: Major
                                                                                      Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                        Avoid too many return statements within this method.
                                                                                        Open

                                                                                                    return $this->getServer()->getURLGenerator();
                                                                                        Severity: Major
                                                                                        Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                          Avoid too many return statements within this method.
                                                                                          Open

                                                                                                      return $this->getServer()->getDateTimeFormatter();
                                                                                          Severity: Major
                                                                                          Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                            Avoid too many return statements within this method.
                                                                                            Open

                                                                                                        return new SessionMiddleware(
                                                                                                            $c['Request'],
                                                                                                            $c['ControllerMethodReflector'],
                                                                                                            $app->getServer()->getSession()
                                                                                                        );
                                                                                            Severity: Major
                                                                                            Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                              Avoid too many return statements within this method.
                                                                                              Open

                                                                                                          return $this->getServer()->getDatabaseConnection();
                                                                                              Severity: Major
                                                                                              Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                Avoid too many return statements within this method.
                                                                                                Open

                                                                                                            return $this->getServer()->getNotificationManager();
                                                                                                Severity: Major
                                                                                                Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                  Avoid too many return statements within this method.
                                                                                                  Open

                                                                                                              return $c;
                                                                                                  Severity: Major
                                                                                                  Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                    Avoid too many return statements within this method.
                                                                                                    Open

                                                                                                                return $server->getCapabilitiesManager();
                                                                                                    Severity: Major
                                                                                                    Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                      Avoid too many return statements within this method.
                                                                                                      Open

                                                                                                                  return $this->getServer()->getEventLogger();
                                                                                                      Severity: Major
                                                                                                      Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                        Avoid too many return statements within this method.
                                                                                                        Open

                                                                                                                    return $this->getServer()->getLogger();
                                                                                                        Severity: Major
                                                                                                        Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                          Avoid too many return statements within this method.
                                                                                                          Open

                                                                                                                      return $this->getServer()->getUserManager();
                                                                                                          Severity: Major
                                                                                                          Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                            Avoid too many return statements within this method.
                                                                                                            Open

                                                                                                                        return new SecurityMiddleware(
                                                                                                                            $c['Request'],
                                                                                                                            $c['ControllerMethodReflector'],
                                                                                                                            $app->getServer()->getNavigationManager(),
                                                                                                                            $app->getServer()->getURLGenerator(),
                                                                                                            Severity: Major
                                                                                                            Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                              Avoid too many return statements within this method.
                                                                                                              Open

                                                                                                                          return $this->getServer()->getConfig();
                                                                                                              Severity: Major
                                                                                                              Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                Avoid too many return statements within this method.
                                                                                                                Open

                                                                                                                            return $this->getServer()->getMimeTypeDetector();
                                                                                                                Severity: Major
                                                                                                                Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                  Avoid too many return statements within this method.
                                                                                                                  Open

                                                                                                                              return $this->getServer()->getHTTPClientService();
                                                                                                                  Severity: Major
                                                                                                                  Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                    Avoid too many return statements within this method.
                                                                                                                    Open

                                                                                                                                return $this->getServer()->getMountManager();
                                                                                                                    Severity: Major
                                                                                                                    Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                      Avoid too many return statements within this method.
                                                                                                                      Open

                                                                                                                                  return $this->getServer()->getThemeService();
                                                                                                                      Severity: Major
                                                                                                                      Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                        Avoid too many return statements within this method.
                                                                                                                        Open

                                                                                                                                    return new TwoFactorMiddleware($twoFactorManager, $userSession, $urlGenerator, $reflector, $request);
                                                                                                                        Severity: Major
                                                                                                                        Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                          Avoid too many return statements within this method.
                                                                                                                          Open

                                                                                                                                      return $this->getServer()->getTagManager();
                                                                                                                          Severity: Major
                                                                                                                          Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                            Avoid too many return statements within this method.
                                                                                                                            Open

                                                                                                                                        return $this->getServer()->getSession();
                                                                                                                            Severity: Major
                                                                                                                            Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                              Avoid too many return statements within this method.
                                                                                                                              Open

                                                                                                                                          return $this->getServer()->getL10NFactory();
                                                                                                                              Severity: Major
                                                                                                                              Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                Open

                                                                                                                                            return new Http($_SERVER, $protocol);
                                                                                                                                Severity: Major
                                                                                                                                Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 30 mins to fix

                                                                                                                                  Function log has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                                                                                                                  Open

                                                                                                                                      public function log($message, $level) {
                                                                                                                                          switch ($level) {
                                                                                                                                              case 'debug':
                                                                                                                                                  $level = \OCP\Util::DEBUG;
                                                                                                                                                  break;
                                                                                                                                  Severity: Minor
                                                                                                                                  Found in lib/private/AppFramework/DependencyInjection/DIContainer.php - About 25 mins to fix

                                                                                                                                  Cognitive Complexity

                                                                                                                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                                                                                                                  A method's cognitive complexity is based on a few simple rules:

                                                                                                                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                                                                                                                  • Code is considered more complex for each "break in the linear flow of the code"
                                                                                                                                  • Code is considered more complex when "flow breaking structures are nested"

                                                                                                                                  Further reading

                                                                                                                                  There are no issues that match your filters.

                                                                                                                                  Category
                                                                                                                                  Status