Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php

Summary

Maintainability
C
1 day
Test Coverage

Function afterException has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    public function afterException($controller, $methodName, \Exception $exception) {
        $headers = [];
        if ($controller instanceof OCSController) {
            if ($this->request->getHeader('OC-RequestAppPassword') === 'true'
                    && ($exception instanceof NotLoggedInException || $exception instanceof LoginException)) {
Severity: Minor
Found in lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method afterException has 57 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function afterException($controller, $methodName, \Exception $exception) {
        $headers = [];
        if ($controller instanceof OCSController) {
            if ($this->request->getHeader('OC-RequestAppPassword') === 'true'
                    && ($exception instanceof NotLoggedInException || $exception instanceof LoginException)) {
Severity: Major
Found in lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php - About 2 hrs to fix

    Function beforeController has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
    Open

        public function beforeController($controller, $methodName) {
        // this will set the current navigation entry of the app, use this only
        // for normal HTML requests and not for AJAX requests
        $this->navigationManager->setActiveEntry($this->appName);
    Severity: Minor
    Found in lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            IRequest $request,
        ControllerMethodReflector $reflector,
        INavigationManager $navigationManager,
        IURLGenerator $urlGenerator,
        ILogger $logger,
    Severity: Major
    Found in lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php - About 1 hr to fix

      Avoid too many return statements within this method.
      Open

                          return $controller->showLoginForm(null, null, null);
      Severity: Major
      Found in lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return $response;
        Severity: Major
        Found in lib/private/AppFramework/Middleware/Security/SecurityMiddleware.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status