Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/DB/MDB2SchemaReader.php

Summary

Maintainability
D
2 days
Test Coverage

Function loadField has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
Open

    private function loadField($table, $xml) {
        $options = ['notnull' => false];
        $primary = null;
        foreach ($xml->children() as $child) {
            /**
Severity: Minor
Found in lib/private/DB/MDB2SchemaReader.php - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method loadField has 105 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function loadField($table, $xml) {
        $options = ['notnull' => false];
        $primary = null;
        foreach ($xml->children() as $child) {
            /**
Severity: Major
Found in lib/private/DB/MDB2SchemaReader.php - About 4 hrs to fix

    Function loadIndex has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

        private function loadIndex($table, $xml) {
        $name = null;
        $fields = [];
        foreach ($xml->children() as $child) {
            /**
    Severity: Minor
    Found in lib/private/DB/MDB2SchemaReader.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method loadIndex has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function loadIndex($table, $xml) {
        $name = null;
        $fields = [];
        foreach ($xml->children() as $child) {
            /**
    Severity: Minor
    Found in lib/private/DB/MDB2SchemaReader.php - About 1 hr to fix

      Function loadTable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function loadTable($schema, $xml) {
        $table = null;
        foreach ($xml->children() as $child) {
            /**
             * @var \SimpleXMLElement $child
      Severity: Minor
      Found in lib/private/DB/MDB2SchemaReader.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status