Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Group/Manager.php

Summary

Maintainability
F
4 days
Test Coverage

File Manager.php has 284 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
 * @author Bart Visscher <bartv@thisnet.nl>
 * @author Bernhard Posselt <dev@bernhard-posselt.com>
Severity: Minor
Found in lib/private/Group/Manager.php - About 2 hrs to fix

    Function search has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

        public function search($search, $limit = null, $offset = null, $scope = null, $alwaysReturnAllMatches = false) {
        $groups = [];
        if ($alwaysReturnAllMatches || $this->userSearch->isSearchable($search)) {
            foreach ($this->backends as $backend) {
                if (!$backend->isVisibleForScope($scope)) {
    Severity: Minor
    Found in lib/private/Group/Manager.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Manager has 22 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Manager extends PublicEmitter implements IGroupManager {
    /**
     * @var GroupInterface[] $backends
     */
    private $backends = [];
    Severity: Minor
    Found in lib/private/Group/Manager.php - About 2 hrs to fix

      Function getUserIdGroups has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          public function getUserIdGroups($uid, $scope = null) {
        if (!isset($this->cachedUserGroups[$uid])) {
            $groups = [];

            foreach ($this->backends as $backend) {
      Severity: Minor
      Found in lib/private/Group/Manager.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getGroupObject has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getGroupObject($gid, $displayName = null) {
        $backends = [];
        foreach ($this->backends as $backend) {
            if ($backend->groupExists($gid)) {
                if ($backend->implementsActions(\OC\Group\Backend::GROUP_DETAILS)) {
      Severity: Minor
      Found in lib/private/Group/Manager.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function displayNamesInGroup has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public function displayNamesInGroup($gid, $search = '', $limit = -1, $offset = 0) {
        $group = $this->get($gid);
        if ($group === null) {
            return [];
        }
      Severity: Minor
      Found in lib/private/Group/Manager.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function findUsersInGroup has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          public function findUsersInGroup($gid, $search = '', $limit = -1, $offset = 0) {
        $group = $this->get($gid);
        if ($group === null) {
            return [];
        }
      Severity: Minor
      Found in lib/private/Group/Manager.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method findUsersInGroup has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function findUsersInGroup($gid, $search = '', $limit = -1, $offset = 0) {
        $group = $this->get($gid);
        if ($group === null) {
            return [];
        }
      Severity: Minor
      Found in lib/private/Group/Manager.php - About 1 hr to fix

        Method displayNamesInGroup has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function displayNamesInGroup($gid, $search = '', $limit = -1, $offset = 0) {
        $group = $this->get($gid);
        if ($group === null) {
            return [];
        }
        Severity: Minor
        Found in lib/private/Group/Manager.php - About 1 hr to fix

          Function createGroup has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function createGroup($gid) {
        if ($gid === '' || $gid === null || \trim($gid) !== $gid) {
            return false;
        } elseif ($group = $this->get($gid)) {
            return $group;
          Severity: Minor
          Found in lib/private/Group/Manager.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method search has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function search($search, $limit = null, $offset = null, $scope = null, $alwaysReturnAllMatches = false) {
          Severity: Minor
          Found in lib/private/Group/Manager.php - About 35 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (!empty($search)) {
            // only user backends have the capability to do a complex search for users
            $searchOffset = 0;
            $searchLimit = $limit * 100;
            if ($limit === -1) {
            Severity: Major
            Found in lib/private/Group/Manager.php and 1 other location - About 6 hrs to fix
            lib/private/Group/Manager.php on lines 448..473

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 206.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if (!empty($search)) {
            // only user backends have the capability to do a complex search for users
            $searchOffset = 0;
            $searchLimit = $limit * 100;
            if ($limit === -1) {
            Severity: Major
            Found in lib/private/Group/Manager.php and 1 other location - About 6 hrs to fix
            lib/private/Group/Manager.php on lines 396..421

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 206.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status