Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/L10N/Factory.php

Summary

Maintainability
C
1 day
Test Coverage

Function setLanguageFromRequest has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

    public function setLanguageFromRequest($app = null) {
        $header = $this->request->getHeader('ACCEPT_LANGUAGE');
        if ($header) {
            $available = $this->findAvailableLanguages($app);
Severity: Minor
Found in lib/private/L10N/Factory.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findLanguage has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function findLanguage($app = null) {
        if ($this->requestLanguage !== '' && $this->languageExists($app, $this->requestLanguage)) {
            return $this->requestLanguage;
        }
Severity: Minor
Found in lib/private/L10N/Factory.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function findAvailableLanguageFiles has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    protected function findAvailableLanguageFiles($dir) {
        $availableLanguageFiles = [];
        if (\is_dir($dir)) {
            $files = \scandir($dir);
            if ($files !== false) {
Severity: Minor
Found in lib/private/L10N/Factory.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setLanguageFromRequest has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function setLanguageFromRequest($app = null) {
        $header = $this->request->getHeader('ACCEPT_LANGUAGE');
        if ($header) {
            $available = $this->findAvailableLanguages($app);
Severity: Minor
Found in lib/private/L10N/Factory.php - About 1 hr to fix

    Method findLanguage has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function findLanguage($app = null) {
        if ($this->requestLanguage !== '' && $this->languageExists($app, $this->requestLanguage)) {
            return $this->requestLanguage;
        }
    Severity: Minor
    Found in lib/private/L10N/Factory.php - About 1 hr to fix

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              IConfig $config,
        IRequest $request,
        IThemeService $themeService,
        IUserSession $userSession = null,
        $serverRoot
      Severity: Minor
      Found in lib/private/L10N/Factory.php - About 35 mins to fix

        Function getL10nFilesForApp has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function getL10nFilesForApp($app, $lang) {
        $languageFiles = [];

        $i18nDir = $this->findL10nDir($app);
        $transFile = \strip_tags($i18nDir) . \strip_tags($lang) . '.json';
        Severity: Minor
        Found in lib/private/L10N/Factory.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function findL10nDirInTheme has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function findL10nDirInTheme(string $themeDir, $app): string {
        if ($app) {
            if (\in_array($app, ['core', 'lib', 'settings'])) {
                $p = $themeDir . '/' . $app . '/l10n/';
            } else {
        Severity: Minor
        Found in lib/private/L10N/Factory.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status