Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/License/MessageService.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method getMessageForLicense has 96 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getMessageForLicense(array $info, string $language = null): array {
        $l = $this->l10nFactory->get('core', $language);

        // check if present
        if ($info['licenseState'] === ILicenseManager::LICENSE_STATE_MISSING) {
Severity: Major
Found in lib/private/License/MessageService.php - About 3 hrs to fix

    Function getMessageForLicense has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getMessageForLicense(array $info, string $language = null): array {
        $l = $this->l10nFactory->get('core', $language);

        // check if present
        if ($info['licenseState'] === ILicenseManager::LICENSE_STATE_MISSING) {
    Severity: Minor
    Found in lib/private/License/MessageService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                    return [
                    'raw_message' => [
                        "Your Enterprise license key is about to expire (days remaining: {$info['daysLeft']}).",
                        'Please contact your administrator or sales@owncloud.com for a new license key.',
                    ],
    Severity: Major
    Found in lib/private/License/MessageService.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return [
                'raw_message' => [
                    $rawMessage,
                ],
                'translated_message' => [
      Severity: Major
      Found in lib/private/License/MessageService.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                        return [
                    'raw_message' => [
                        "The registered enterprise license key expires in {$info['daysLeft']} days",
                    ],
                    'translated_message' => [
        Severity: Major
        Found in lib/private/License/MessageService.php - About 30 mins to fix

          There are no issues that match your filters.

          Category
          Status