Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Lock/DBLockingProvider.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function acquireLock has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public function acquireLock($path, $type) {
        if (\strlen($path) > 64) { // max length in file_locks
            throw new \InvalidArgumentException("Lock key length too long");
        }
        $expire = $this->getExpireTime();
Severity: Minor
Found in lib/private/Lock/DBLockingProvider.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method acquireLock has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function acquireLock($path, $type) {
        if (\strlen($path) > 64) { // max length in file_locks
            throw new \InvalidArgumentException("Lock key length too long");
        }
        $expire = $this->getExpireTime();
Severity: Minor
Found in lib/private/Lock/DBLockingProvider.php - About 1 hr to fix

    Function isLocked has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function isLocked($path, $type) {
        if ($this->hasAcquiredLock($path, $type)) {
            return true;
        }
        $query = $this->connection->prepare('SELECT `lock` from `*PREFIX*file_locks` WHERE `key` = ?');
    Severity: Minor
    Found in lib/private/Lock/DBLockingProvider.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this method.
    Open

                return false;
    Severity: Major
    Found in lib/private/Lock/DBLockingProvider.php - About 30 mins to fix

      Function changeLock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function changeLock($path, $targetType) {
        $expire = $this->getExpireTime();
        if ($targetType === self::LOCK_SHARED) {
            $result = $this->connection->executeUpdate(
                'UPDATE `*PREFIX*file_locks` SET `lock` = 1, `ttl` = ? WHERE `key` = ? AND `lock` = -1',
      Severity: Minor
      Found in lib/private/Lock/DBLockingProvider.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status