Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Lock/MemcacheLockingProvider.php

Summary

Maintainability
A
1 hr
Test Coverage

Function changeLock has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    public function changeLock($path, $targetType) {
        if ($targetType === self::LOCK_SHARED) {
            if (!$this->hasAcquiredLock($path, self::LOCK_EXCLUSIVE)) {
                // trying to change a lock that we haven't acquired -> throw exception
                \OCP\Util::writeLog('core', "trying lock change to type $targetType for $path, but the lock hasn't been acquired before!!", \OCP\Util::WARN);
Severity: Minor
Found in lib/private/Lock/MemcacheLockingProvider.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function acquireLock has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function acquireLock($path, $type) {
        if (\strlen($path) > 64) { // max length in file_locks
            throw new \InvalidArgumentException('Lock key length too long');
        }
        if ($type === self::LOCK_SHARED) {
Severity: Minor
Found in lib/private/Lock/MemcacheLockingProvider.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status