Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/Repair/RepairMimeTypes.php

Summary

Maintainability
B
5 hrs
Test Coverage

RepairMimeTypes has 24 functions (exceeds 20 allowed). Consider refactoring.
Open

class RepairMimeTypes implements IRepairStep {
    /**
     * @var \OCP\IConfig
     */
    protected $config;
Severity: Minor
Found in lib/private/Repair/RepairMimeTypes.php - About 2 hrs to fix

    Method run has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function run(IOutput $out) {
        $ocVersionFromBeforeUpdate = $this->config->getSystemValue('version', '0.0.0');

        // NOTE TO DEVELOPERS: when adding new mime types, please make sure to
        // add a version comparison to avoid doing it every time
    Severity: Minor
    Found in lib/private/Repair/RepairMimeTypes.php - About 1 hr to fix

      Function repairMimetypes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          private function repairMimetypes($wrongMimetypes) {
        foreach ($wrongMimetypes as $wrong => $correct) {
            // do we need to remove a wrong mimetype?
            $result = \OC_DB::executeAudited(self::getIdStmt(), [$wrong]);
            $wrongId = $result->fetchOne();
      Severity: Minor
      Found in lib/private/Repair/RepairMimeTypes.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status