owncloud/core

View on GitHub
lib/private/Server.php

Summary

Maintainability
F
1 wk
Test Coverage

Method __construct has 761 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function __construct($webRoot, \OC\Config $config) {
        parent::__construct();
        $this->webRoot = $webRoot;

        $this->registerService('SettingsManager', function (Server $c) {
Severity: Major
Found in lib/private/Server.php - About 3 days to fix

    File Server.php has 1168 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
     * @author Bart Visscher <bartv@thisnet.nl>
     * @author Bernhard Posselt <dev@bernhard-posselt.com>
    Severity: Major
    Found in lib/private/Server.php - About 3 days to fix

      Server has 87 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class Server extends ServerContainer implements IServerContainer, IServiceLoader {
          use EventEmitterTrait;
          /** @var string */
          private $webRoot;
      
      
      Severity: Major
      Found in lib/private/Server.php - About 1 day to fix

        Function load has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            public function load(array $xmlPath, IUser $user = null) {
                $appManager = $this->getAppManager();
                $allApps = $appManager->getEnabledAppsForUser($user);
        
                foreach ($allApps as $appId) {
        Severity: Minor
        Found in lib/private/Server.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

                    return new TagManager($tagMapper, $c->getUserSession());
        Severity: Major
        Found in lib/private/Server.php - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return new Authentication\Token\DefaultTokenMapper($dbConnection);
          Severity: Major
          Found in lib/private/Server.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return true;
            Severity: Major
            Found in lib/private/Server.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return $userSession;
              Severity: Major
              Found in lib/private/Server.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                            return $router;
                Severity: Major
                Found in lib/private/Server.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                              return new CredentialsManager($c->getCrypto(), $c->getDatabaseConnection());
                  Severity: Major
                  Found in lib/private/Server.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                return new NoopLockingProvider();
                    Severity: Major
                    Found in lib/private/Server.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return new CryptoWrapper(
                                      $c->getCrypto(),
                                      $c->getSecureRandom(),
                                      $request,
                                      $c->getTimeFactory()
                      Severity: Major
                      Found in lib/private/Server.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                    return $this;
                        Severity: Major
                        Found in lib/private/Server.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                      return $groupManager;
                          Severity: Major
                          Found in lib/private/Server.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return new \OC\AllConfig(
                                            $c->getSystemConfig(),
                                            $c->getEventDispatcher()
                                        );
                            Severity: Major
                            Found in lib/private/Server.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return new Log($logger);
                              Severity: Major
                              Found in lib/private/Server.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                            return new \OC\BackgroundJob\JobList(
                                                $c->getDatabaseConnection(),
                                                $config,
                                                new TimeFactory(),
                                                $c->getLogger()
                                Severity: Major
                                Found in lib/private/Server.php - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                              return new TempManager(
                                                  $c->getLogger(),
                                                  $c->getConfig()
                                              );
                                  Severity: Major
                                  Found in lib/private/Server.php - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                                return new ContentSecurityPolicyManager();
                                    Severity: Major
                                    Found in lib/private/Server.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                  return new UserStoragesService(
                                                      $c->query('StoragesBackendService'),
                                                      $c->query('StoragesDBConfigService'),
                                                      $c->query('UserSession'),
                                                      $c->query('UserMountCache'),
                                      Severity: Major
                                      Found in lib/private/Server.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                    return new \OC\Authentication\Token\DefaultTokenProvider($mapper, $crypto, $config, $logger, $timeFactory);
                                        Severity: Major
                                        Found in lib/private/Server.php - About 30 mins to fix

                                          Avoid too many return statements within this method.
                                          Open

                                                      return new TimeFactory();
                                          Severity: Major
                                          Found in lib/private/Server.php - About 30 mins to fix

                                            Avoid too many return statements within this method.
                                            Open

                                                            return new \OC\Memcache\Factory(
                                                                $prefix,
                                                                $c->getLogger(),
                                                                $config->getSystemValue('memcache.local', null),
                                                                $config->getSystemValue('memcache.distributed', null),
                                            Severity: Major
                                            Found in lib/private/Server.php - About 30 mins to fix

                                              Avoid too many return statements within this method.
                                              Open

                                                          return new DateTimeZone(
                                                              $c->getConfig(),
                                                              $c->getSession()
                                                          );
                                              Severity: Major
                                              Found in lib/private/Server.php - About 30 mins to fix

                                                Avoid too many return statements within this method.
                                                Open

                                                            return $manager;
                                                Severity: Major
                                                Found in lib/private/Server.php - About 30 mins to fix

                                                  Avoid too many return statements within this method.
                                                  Open

                                                              return new Request(
                                                                  [
                                                                      'get' => $_GET,
                                                                      'post' => $_POST,
                                                                      'files' => $_FILES,
                                                  Severity: Major
                                                  Found in lib/private/Server.php - About 30 mins to fix

                                                    Avoid too many return statements within this method.
                                                    Open

                                                                return new TagMapper($c->getDatabaseConnection());
                                                    Severity: Major
                                                    Found in lib/private/Server.php - About 30 mins to fix

                                                      Avoid too many return statements within this method.
                                                      Open

                                                                  return $c->query('SystemTagManagerFactory')->getObjectMapper();
                                                      Severity: Major
                                                      Found in lib/private/Server.php - About 30 mins to fix

                                                        Avoid too many return statements within this method.
                                                        Open

                                                                        return new \OC\OCS\CoreCapabilities($c->getConfig(), $c->getURLGenerator());
                                                        Severity: Major
                                                        Found in lib/private/Server.php - About 30 mins to fix

                                                          Avoid too many return statements within this method.
                                                          Open

                                                                      return new CsrfTokenManager(
                                                                          $tokenGenerator,
                                                                          $sessionStorage
                                                                      );
                                                          Severity: Major
                                                          Found in lib/private/Server.php - About 30 mins to fix

                                                            Avoid too many return statements within this method.
                                                            Open

                                                                        return new \OC\L10N\Factory(
                                                                            $c->getConfig(),
                                                                            $c->getRequest(),
                                                                            $c->getThemeService(),
                                                                            $c->getUserSession(),
                                                            Severity: Major
                                                            Found in lib/private/Server.php - About 30 mins to fix

                                                              Avoid too many return statements within this method.
                                                              Open

                                                                          return new AsyncBus($jobList);
                                                              Severity: Major
                                                              Found in lib/private/Server.php - About 30 mins to fix

                                                                Avoid too many return statements within this method.
                                                                Open

                                                                            return new Search();
                                                                Severity: Major
                                                                Found in lib/private/Server.php - About 30 mins to fix

                                                                  Avoid too many return statements within this method.
                                                                  Open

                                                                              return new Db($c->getDatabaseConnection());
                                                                  Severity: Major
                                                                  Found in lib/private/Server.php - About 30 mins to fix

                                                                    Avoid too many return statements within this method.
                                                                    Open

                                                                                return new \OC\App\AppManager(
                                                                                    $c->getUserSession(),
                                                                                    $appConfig,
                                                                                    $groupManager,
                                                                                    $c->getMemCacheFactory(),
                                                                    Severity: Major
                                                                    Found in lib/private/Server.php - About 30 mins to fix

                                                                      Avoid too many return statements within this method.
                                                                      Open

                                                                                  return new \OC\Files\Type\Detection(
                                                                                      $c->getURLGenerator(),
                                                                                      \OC::$SERVERROOT . '/config/',
                                                                                      \OC::$SERVERROOT . '/resources/config/'
                                                                                  );
                                                                      Severity: Major
                                                                      Found in lib/private/Server.php - About 30 mins to fix

                                                                        Avoid too many return statements within this method.
                                                                        Open

                                                                                    return $root;
                                                                        Severity: Major
                                                                        Found in lib/private/Server.php - About 30 mins to fix

                                                                          Avoid too many return statements within this method.
                                                                          Open

                                                                                      return new AccountMapper($c->getConfig(), $c->getDatabaseConnection(), new AccountTermMapper($c->getDatabaseConnection()));
                                                                          Severity: Major
                                                                          Found in lib/private/Server.php - About 30 mins to fix

                                                                            Avoid too many return statements within this method.
                                                                            Open

                                                                                        return new \OC\User\Manager(
                                                                                            $c->getConfig(),
                                                                                            $c->getLogger(),
                                                                                            $c->getAccountMapper(),
                                                                                            new SyncService(
                                                                            Severity: Major
                                                                            Found in lib/private/Server.php - About 30 mins to fix

                                                                              Avoid too many return statements within this method.
                                                                              Open

                                                                                                  return true;
                                                                              Severity: Major
                                                                              Found in lib/private/Server.php - About 30 mins to fix

                                                                                Avoid too many return statements within this method.
                                                                                Open

                                                                                            return new AvatarManager(
                                                                                                $c->getUserManager(),
                                                                                                $c->getLazyRootFolder(),  // initialize the root folder lazily
                                                                                                $c->getL10N('lib'),
                                                                                                $c->getLogger()
                                                                                Severity: Major
                                                                                Found in lib/private/Server.php - About 30 mins to fix

                                                                                  Avoid too many return statements within this method.
                                                                                  Open

                                                                                              return new WebDavClientService(
                                                                                                  $c->getConfig(),
                                                                                                  new \OC\Security\CertificateManager($uid, new View(), $c->getConfig())
                                                                                              );
                                                                                  Severity: Major
                                                                                  Found in lib/private/Server.php - About 30 mins to fix

                                                                                    Avoid too many return statements within this method.
                                                                                    Open

                                                                                                return new DateTimeFormatter(
                                                                                                    $c->getDateTimeZone()->getTimeZone(),
                                                                                                    $c->getL10N('lib', $language)
                                                                                                );
                                                                                    Severity: Major
                                                                                    Found in lib/private/Server.php - About 30 mins to fix

                                                                                      Avoid too many return statements within this method.
                                                                                      Open

                                                                                                  return $manager;
                                                                                      Severity: Major
                                                                                      Found in lib/private/Server.php - About 30 mins to fix

                                                                                        Avoid too many return statements within this method.
                                                                                        Open

                                                                                                    return $policyManager;
                                                                                        Severity: Major
                                                                                        Found in lib/private/Server.php - About 30 mins to fix

                                                                                          Avoid too many return statements within this method.
                                                                                          Open

                                                                                                      return new LazyRoot(function () use ($c) {
                                                                                                          return $c->getRootFolder();
                                                                                                      });
                                                                                          Severity: Major
                                                                                          Found in lib/private/Server.php - About 30 mins to fix

                                                                                            Avoid too many return statements within this method.
                                                                                            Open

                                                                                                        return new \OC\NavigationManager(
                                                                                                            $c->getAppManager(),
                                                                                                            $c->getURLGenerator(),
                                                                                                            $c->getL10NFactory(),
                                                                                                            $c->getUserSession(),
                                                                                            Severity: Major
                                                                                            Found in lib/private/Server.php - About 30 mins to fix

                                                                                              Avoid too many return statements within this method.
                                                                                              Open

                                                                                                          return new \OC\SystemConfig($config);
                                                                                              Severity: Major
                                                                                              Found in lib/private/Server.php - About 30 mins to fix

                                                                                                Avoid too many return statements within this method.
                                                                                                Open

                                                                                                            return new \OC\AppConfig($c->getDatabaseConnection());
                                                                                                Severity: Major
                                                                                                Found in lib/private/Server.php - About 30 mins to fix

                                                                                                  Avoid too many return statements within this method.
                                                                                                  Open

                                                                                                              return new \OC\AppHelper();
                                                                                                  Severity: Major
                                                                                                  Found in lib/private/Server.php - About 30 mins to fix

                                                                                                    Avoid too many return statements within this method.
                                                                                                    Open

                                                                                                                return new \OC\Memcache\Factory(
                                                                                                                    '',
                                                                                                                    $c->getLogger(),
                                                                                                                    '\\OC\\Memcache\\ArrayCache',
                                                                                                                    '\\OC\\Memcache\\ArrayCache',
                                                                                                    Severity: Major
                                                                                                    Found in lib/private/Server.php - About 30 mins to fix

                                                                                                      Avoid too many return statements within this method.
                                                                                                      Open

                                                                                                                  return $mountCache;
                                                                                                      Severity: Major
                                                                                                      Found in lib/private/Server.php - About 30 mins to fix

                                                                                                        Avoid too many return statements within this method.
                                                                                                        Open

                                                                                                                    return new GlobalStoragesService(
                                                                                                                        $c->query('StoragesBackendService'),
                                                                                                                        $c->query('StoragesDBConfigService'),
                                                                                                                        $c->query('UserMountCache'),
                                                                                                                        $c->query('Crypto')
                                                                                                        Severity: Major
                                                                                                        Found in lib/private/Server.php - About 30 mins to fix

                                                                                                          Avoid too many return statements within this method.
                                                                                                          Open

                                                                                                                      return new UserGlobalStoragesService(
                                                                                                                          $c->query('StoragesBackendService'),
                                                                                                                          $c->query('StoragesDBConfigService'),
                                                                                                                          $c->query('UserSession'),
                                                                                                                          $c->query('GroupManager'),
                                                                                                          Severity: Major
                                                                                                          Found in lib/private/Server.php - About 30 mins to fix

                                                                                                            Avoid too many return statements within this method.
                                                                                                            Open

                                                                                                                        return $c->query('SystemTagManagerFactory')->getManager();
                                                                                                            Severity: Major
                                                                                                            Found in lib/private/Server.php - About 30 mins to fix

                                                                                                              Avoid too many return statements within this method.
                                                                                                              Open

                                                                                                                          return new URLGenerator(
                                                                                                                              $config,
                                                                                                                              $cacheFactory,
                                                                                                                              $router,
                                                                                                                              new \OC\Helper\EnvironmentHelper()
                                                                                                              Severity: Major
                                                                                                              Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                Avoid too many return statements within this method.
                                                                                                                Open

                                                                                                                            return new ClientService(
                                                                                                                                $c->getConfig(),
                                                                                                                                new \OC\Security\CertificateManager($uid, new View(), $c->getConfig())
                                                                                                                            );
                                                                                                                Severity: Major
                                                                                                                Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                  Avoid too many return statements within this method.
                                                                                                                  Open

                                                                                                                              return new Mailer(
                                                                                                                                  $c->getConfig(),
                                                                                                                                  $c->getLogger(),
                                                                                                                                  new \OC_Defaults()
                                                                                                                              );
                                                                                                                  Severity: Major
                                                                                                                  Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                    Avoid too many return statements within this method.
                                                                                                                    Open

                                                                                                                                return new \OC\Files\Mount\Manager();
                                                                                                                    Severity: Major
                                                                                                                    Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                      Avoid too many return statements within this method.
                                                                                                                      Open

                                                                                                                                  return $factory->getManager();
                                                                                                                      Severity: Major
                                                                                                                      Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                        Avoid too many return statements within this method.
                                                                                                                        Open

                                                                                                                                    return $service;
                                                                                                                        Severity: Major
                                                                                                                        Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                          Avoid too many return statements within this method.
                                                                                                                          Open

                                                                                                                                      return new RedisFactory($systemConfig);
                                                                                                                          Severity: Major
                                                                                                                          Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                            Avoid too many return statements within this method.
                                                                                                                            Open

                                                                                                                                        return $connection;
                                                                                                                            Severity: Major
                                                                                                                            Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                              Avoid too many return statements within this method.
                                                                                                                              Open

                                                                                                                                          return new HTTPHelper(
                                                                                                                                              $config,
                                                                                                                                              $c->getHTTPClientService()
                                                                                                                                          );
                                                                                                                              Severity: Major
                                                                                                                              Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                Open

                                                                                                                                                return new DBLockingProvider($c->getDatabaseConnection(), $c->getLogger(), new TimeFactory(), $ttl);
                                                                                                                                Severity: Major
                                                                                                                                Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                  Open

                                                                                                                                              return new EventDispatcher();
                                                                                                                                  Severity: Major
                                                                                                                                  Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                    Open

                                                                                                                                                return new Cache\File();
                                                                                                                                    Severity: Major
                                                                                                                                    Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                      Open

                                                                                                                                                          return new MemcacheLockingProvider($memcache, $ttl);
                                                                                                                                      Severity: Major
                                                                                                                                      Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                        Open

                                                                                                                                                    return new \OC\Files\Type\Loader(
                                                                                                                                                        $c->getDatabaseConnection(),
                                                                                                                                                        $c->getMemCacheFactory()
                                                                                                                                                    );
                                                                                                                                        Severity: Major
                                                                                                                                        Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                          Open

                                                                                                                                                      return new LicenseManager(
                                                                                                                                                          $c->query(LicenseFetcher::class),
                                                                                                                                                          // can't query for MessageService because there is no implementation
                                                                                                                                                          // registered for the \OCP\L10N\IFactory interface in the server.
                                                                                                                                                          new MessageService(
                                                                                                                                          Severity: Major
                                                                                                                                          Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                            Open

                                                                                                                                                        return new Encryption\File($util);
                                                                                                                                            Severity: Major
                                                                                                                                            Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                              Open

                                                                                                                                                          return new Encryption\Keys\Storage(
                                                                                                                                                              $view,
                                                                                                                                                              $util,
                                                                                                                                                              $c->getUserSession()
                                                                                                                                                          );
                                                                                                                                              Severity: Major
                                                                                                                                              Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                Open

                                                                                                                                                            return $factory;
                                                                                                                                                Severity: Major
                                                                                                                                                Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                  Open

                                                                                                                                                              return new \OC\Activity\Manager(
                                                                                                                                                                  $c->getRequest(),
                                                                                                                                                                  $c->getUserSession(),
                                                                                                                                                                  $c->getConfig()
                                                                                                                                                              );
                                                                                                                                                  Severity: Major
                                                                                                                                                  Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                    Open

                                                                                                                                                                return new ThemeService(
                                                                                                                                                                    $this->getSystemConfig()->getValue('theme'),
                                                                                                                                                                    $c->getAppManager(),
                                                                                                                                                                    new \OC\Helper\EnvironmentHelper()
                                                                                                                                                                );
                                                                                                                                                    Severity: Major
                                                                                                                                                    Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                      Open

                                                                                                                                                                  return new SecureRandom();
                                                                                                                                                      Severity: Major
                                                                                                                                                      Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                        Open

                                                                                                                                                                    return new Hasher($c->getConfig());
                                                                                                                                                        Severity: Major
                                                                                                                                                        Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                          Open

                                                                                                                                                                      return $eventLogger;
                                                                                                                                                          Severity: Major
                                                                                                                                                          Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                            Open

                                                                                                                                                                        return $queryLogger;
                                                                                                                                                            Severity: Major
                                                                                                                                                            Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                              Avoid too many return statements within this method.
                                                                                                                                                              Open

                                                                                                                                                                          return new Manager($c->getEventDispatcher());
                                                                                                                                                              Severity: Major
                                                                                                                                                              Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                                Avoid too many return statements within this method.
                                                                                                                                                                Open

                                                                                                                                                                            return new \OC\Authentication\TwoFactorAuth\Manager(
                                                                                                                                                                                $c->getAppManager(),
                                                                                                                                                                                $c->getSession(),
                                                                                                                                                                                $c->getGroupManager(),
                                                                                                                                                                                $c->getConfig(),
                                                                                                                                                                Severity: Major
                                                                                                                                                                Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                                  Avoid too many return statements within this method.
                                                                                                                                                                  Open

                                                                                                                                                                              return new Checker(
                                                                                                                                                                                  new EnvironmentHelper(),
                                                                                                                                                                                  new FileAccessHelper(),
                                                                                                                                                                                  new AppLocator(),
                                                                                                                                                                                  $config,
                                                                                                                                                                  Severity: Major
                                                                                                                                                                  Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                                    Avoid too many return statements within this method.
                                                                                                                                                                    Open

                                                                                                                                                                                return $manager;
                                                                                                                                                                    Severity: Major
                                                                                                                                                                    Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                                      Avoid too many return statements within this method.
                                                                                                                                                                      Open

                                                                                                                                                                                  return new Crypto($c->getConfig(), $c->getSecureRandom());
                                                                                                                                                                      Severity: Major
                                                                                                                                                                      Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                                        Avoid too many return statements within this method.
                                                                                                                                                                        Open

                                                                                                                                                                                    return new IniGetWrapper();
                                                                                                                                                                        Severity: Major
                                                                                                                                                                        Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                                          Avoid too many return statements within this method.
                                                                                                                                                                          Open

                                                                                                                                                                                      return new TrustedDomainHelper($this->getConfig());
                                                                                                                                                                          Severity: Major
                                                                                                                                                                          Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                                            Avoid too many return statements within this method.
                                                                                                                                                                            Open

                                                                                                                                                                                        return new DBConfigService(
                                                                                                                                                                                            $c->getDatabaseConnection(),
                                                                                                                                                                                            $c->getCrypto()
                                                                                                                                                                                        );
                                                                                                                                                                            Severity: Major
                                                                                                                                                                            Found in lib/private/Server.php - About 30 mins to fix

                                                                                                                                                                              There are no issues that match your filters.

                                                                                                                                                                              Category
                                                                                                                                                                              Status