Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/legacy/db.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function executeAudited has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    public static function executeAudited($stmt, array $parameters = null) {
        if (\is_string($stmt)) {
            // convert to an array with 'sql'
            if (\stripos($stmt, 'LIMIT') !== false) { //OFFSET requires LIMIT, so we only need to check for LIMIT
                // TODO try to convert LIMIT OFFSET notation to parameters
Severity: Minor
Found in lib/private/legacy/db.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method executeAudited has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function executeAudited($stmt, array $parameters = null) {
        if (\is_string($stmt)) {
            // convert to an array with 'sql'
            if (\stripos($stmt, 'LIMIT') !== false) { //OFFSET requires LIMIT, so we only need to check for LIMIT
                // TODO try to convert LIMIT OFFSET notation to parameters
Severity: Minor
Found in lib/private/legacy/db.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return false;
    Severity: Major
    Found in lib/private/legacy/db.php - About 30 mins to fix

      Function isManipulation has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function isManipulation($sql) {
        $selectOccurrence = \stripos($sql, 'SELECT');
        if ($selectOccurrence !== false && $selectOccurrence < 10) {
            return false;
        }
      Severity: Minor
      Found in lib/private/legacy/db.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status