Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/legacy/files.php

Summary

Maintainability
F
3 days
Test Coverage

Function get has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    public static function get($dir, $files, $params = null) {
        $view = \OC\Files\Filesystem::getView();

        if (!\is_array($files)) {
            // "files" contains a string with a filename
Severity: Minor
Found in lib/private/legacy/files.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function parseHttpRangeHeader has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    private static function parseHttpRangeHeader($rangeHeaderPos, $fileSize) {
        $rArray=\explode(',', $rangeHeaderPos);
        $minOffset = 0;
        $ind = 0;
Severity: Minor
Found in lib/private/legacy/files.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method get has 86 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function get($dir, $files, $params = null) {
        $view = \OC\Files\Filesystem::getView();

        if (!\is_array($files)) {
            // "files" contains a string with a filename
Severity: Major
Found in lib/private/legacy/files.php - About 3 hrs to fix

    Function getSingleFile has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        private static function getSingleFile($view, $dir, $name, $params) {
        $filename = "{$dir}/{$name}";
        OC_Util::obEnd();
        $view->lockFile($filename, ILockingProvider::LOCK_SHARED);
    Severity: Minor
    Found in lib/private/legacy/files.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method getSingleFile has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private static function getSingleFile($view, $dir, $name, $params) {
        $filename = "{$dir}/{$name}";
        OC_Util::obEnd();
        $view->lockFile($filename, ILockingProvider::LOCK_SHARED);
    Severity: Major
    Found in lib/private/legacy/files.php - About 2 hrs to fix

      File files.php has 253 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/**
 * @author Arthur Schiwon <blizzz@arthur-schiwon.de>
 * @author Bart Visscher <bartv@thisnet.nl>
 * @author Björn Schießle <bjoern@schiessle.org>
      Severity: Minor
      Found in lib/private/legacy/files.php - About 2 hrs to fix

        Method parseHttpRangeHeader has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private static function parseHttpRangeHeader($rangeHeaderPos, $fileSize) {
        $rArray=\explode(',', $rangeHeaderPos);
        $minOffset = 0;
        $ind = 0;
        Severity: Minor
        Found in lib/private/legacy/files.php - About 1 hr to fix

          Function sendHeaders has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

              private static function sendHeaders($filename, $name, array $rangeArray) {
        OC_Response::setContentDispositionHeader($name, 'attachment');
        \header('Content-Transfer-Encoding: binary', true);
        OC_Response::disableCaching();
        $fileSize = \OC\Files\Filesystem::filesize($filename);
          Severity: Minor
          Found in lib/private/legacy/files.php - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private static function lockFiles($view, $dir, $files) {
        foreach ($files as $file) {
            $filePath = "{$dir}/{$file}";
            $view->lockFile($filePath, ILockingProvider::LOCK_SHARED);
            if ($view->is_dir($filePath)) {
          Severity: Major
          Found in lib/private/legacy/files.php and 1 other location - About 2 hrs to fix
          lib/private/legacy/files.php on lines 366..381

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 130.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              private static function unlockFiles($view, $dir, $files) {
        foreach ($files as $file) {
            $filePath = "{$dir}/{$file}";
            $view->unlockFile($filePath, ILockingProvider::LOCK_SHARED);
            if ($view->is_dir($filePath)) {
          Severity: Major
          Found in lib/private/legacy/files.php and 1 other location - About 2 hrs to fix
          lib/private/legacy/files.php on lines 344..359

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 130.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status