Sign upLogin

owncloud/core

View on GitHub
Star
lib/private/legacy/template.php

Summary

Maintainability
C
7 hrs
Test Coverage

Method initTemplateEngine has 64 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function initTemplateEngine($renderAs) {
        if (self::$initTemplateEngineFirstRun) {
            //apps that started before the template initialization can load their own scripts/styles
            //so to make sure this scripts/styles here are loaded first we use OC_Util::addScript() with $prepend=true
            //meaning the last script/style in this list will be loaded first
Severity: Major
Found in lib/private/legacy/template.php - About 2 hrs to fix

    Function initTemplateEngine has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function initTemplateEngine($renderAs) {
        if (self::$initTemplateEngineFirstRun) {
            //apps that started before the template initialization can load their own scripts/styles
            //so to make sure this scripts/styles here are loaded first we use OC_Util::addScript() with $prepend=true
            //meaning the last script/style in this list will be loaded first
    Severity: Minor
    Found in lib/private/legacy/template.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method printExceptionErrorPage has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function printExceptionErrorPage($exception, $fetchPage = false) {
        try {
            $trace = Log::replaceSensitiveData($exception->getTraceAsString());

            $request = \OC::$server->getRequest();
    Severity: Minor
    Found in lib/private/legacy/template.php - About 1 hr to fix

      Function fetchPage has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          public function fetchPage($additionalParams = null) {
        $data = parent::fetchPage($additionalParams);

        if ($this->renderAs) {
            $page = new TemplateLayout($this->renderAs, $this->app);
      Severity: Minor
      Found in lib/private/legacy/template.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function __construct($app, $name, $renderAs = "", $registerCall = true, $languageCode = null) {
      Severity: Minor
      Found in lib/private/legacy/template.php - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status