owncloud/core

Method __construct has 219 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    public function __construct(array $urlParams=[]) {
        parent::__construct('settings', $urlParams);

        $container = $this->getContainer();

Avoid too many return statements within this method.

Open

            return new UsersController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('UserManager'),
                $c->query('GroupManager'),

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getMemCacheFactory();

Avoid too many return statements within this method.

Open

            return Util::getDefaultEmailAddress('no-reply');

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getNavigationManager();

Avoid too many return statements within this method.

Open

            return new CheckSetupController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('Config'),
                $c->query('ClientService'),

Avoid too many return statements within this method.

Open

            return \OC_User::isAdminUser(\OC_User::getUser());

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getLogger();

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getDatabaseConnection();

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getGroupManager();

Avoid too many return statements within this method.

Open

            return new CertificateController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('CertificateManager'),
                $c->query('SystemCertificateManager'),

Avoid too many return statements within this method.

Open

            return new \OC_Defaults;

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getHTTPClientService();

Avoid too many return statements within this method.

Open

            return new SubadminMiddleware(
                $c->query('ControllerMethodReflector'),
                $c->query('IsSubAdmin')
            );

Avoid too many return statements within this method.

Open

            return new \OC_Util();

Avoid too many return statements within this method.

Open

            return new TimeFactory();

Avoid too many return statements within this method.

Open

            return $server->getIntegrityCodeChecker();

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getCertificateManager(null);

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getSecureRandom();

Avoid too many return statements within this method.

Open

            return new LogSettingsController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('Config'),
                $c->query('L10N')

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getMailer();

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getAppManager();

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getCertificateManager();

Avoid too many return statements within this method.

Open

            return new GroupsController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('GroupManager'),
                $c->query('UserSession'),

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getSettingsManager();

Avoid too many return statements within this method.

Open

            return $isSubAdmin;

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getL10N('settings');

Avoid too many return statements within this method.

Open

            return new CorsController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('UserSession'),
                $c->query('Logger'),

Avoid too many return statements within this method.

Open

            return new AppConfigController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('ServerContainer')->getAppConfig()
            );

Avoid too many return statements within this method.

Open

            return new LegalSettingsController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('L10N'),
                $c->query('Config')

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getConfig();

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getUserSession();

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getUserManager();

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getURLGenerator();

Avoid too many return statements within this method.

Open

            return $c->query('ServerContainer')->getOcsClient();

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $container->registerService('CheckSetupController', function (IContainer $c) {
            return new CheckSetupController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('Config'),

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        $container->registerService('CorsController', function (IContainer $c) {
            return new CorsController(
                $c->query('AppName'),
                $c->query('Request'),
                $c->query('UserSession'),

• Read up
  Read up