Sign upLogin

owncloud/core

View on GitHub
Star
settings/ChangePassword/Controller.php

Summary

Maintainability
C
1 day
Test Coverage

Method changeUserPassword has 102 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function changeUserPassword($args) {
        // Check if we are an user
        \OC_JSON::callCheck();
        \OC_JSON::checkLoggedIn();
Severity: Major
Found in settings/ChangePassword/Controller.php - About 4 hrs to fix

    Function changeUserPassword has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function changeUserPassword($args) {
        // Check if we are an user
        \OC_JSON::callCheck();
        \OC_JSON::checkLoggedIn();
    Severity: Minor
    Found in settings/ChangePassword/Controller.php - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method changePersonalPassword has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function changePersonalPassword($args) {
        // Check if we are an user
        \OC_JSON::callCheck();
        \OC_JSON::checkLoggedIn();
    Severity: Minor
    Found in settings/ChangePassword/Controller.php - About 1 hr to fix

      Function changePersonalPassword has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function changePersonalPassword($args) {
        // Check if we are an user
        \OC_JSON::callCheck();
        \OC_JSON::checkLoggedIn();
      Severity: Minor
      Found in settings/ChangePassword/Controller.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status