Sign upLogin

owncloud/core

View on GitHub
Star
settings/Controller/MailSettingsController.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method sendTestMail has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function sendTestMail() {
        $email = $this->request->getParam('mail_to_address');

        if (empty($email)) {
            $email = $this->userSession->getUser()->getEMailAddress();
Severity: Minor
Found in settings/Controller/MailSettingsController.php - About 1 hr to fix

    Method __construct has 8 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $appName,
        IRequest $request,
        IL10N $l10n,
        IConfig $config,
        Session $userSession,
    Severity: Major
    Found in settings/Controller/MailSettingsController.php - About 1 hr to fix

      Method setMailSettings has 8 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              $mail_domain,
        $mail_from_address,
        $mail_smtpmode,
        $mail_smtpsecure,
        $mail_smtphost,
      Severity: Major
      Found in settings/Controller/MailSettingsController.php - About 1 hr to fix

        There are no issues that match your filters.

        Category
        Status