Sign upLogin

owncloud/core

View on GitHub
Star
settings/Panels/Admin/SecurityWarning.php

Summary

Maintainability
A
3 hrs
Test Coverage

Method getPanel has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function getPanel() {
        // create htaccess test file
        $util = new \OC_Util();
        $util->createHtaccessTestFile($this->config);
Severity: Minor
Found in settings/Panels/Admin/SecurityWarning.php - About 1 hr to fix

    Function getPanel has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function getPanel() {
        // create htaccess test file
        $util = new \OC_Util();
        $util->createHtaccessTestFile($this->config);
    Severity: Minor
    Found in settings/Panels/Admin/SecurityWarning.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            IL10N $l,
        IConfig $config,
        IDBConnection $dbconnection,
        Helper $helper,
        ILockingProvider $lockingProvider
    Severity: Minor
    Found in settings/Panels/Admin/SecurityWarning.php - About 35 mins to fix

      There are no issues that match your filters.

      Category
      Status