oysterprotocol/webinterface

View on GitHub

Showing 10 of 10 total issues

Function render has 210 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render() {
    const {
      alphaBroker,
      betaBroker,
      selectAlphaBroker,
Severity: Major
Found in src/components/upload-form/upload-slide.tsx - About 1 day to fix

    File upload-slide.tsx has 277 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import React, { Component } from "react";
    import Select from "react-select";
    import "react-select/dist/react-select.css";
    
    import { API, FILE } from "../../config";
    Severity: Minor
    Found in src/components/upload-form/upload-slide.tsx - About 2 hrs to fix

      Function spunkySlider has 53 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          spunkySlider: function() {
              var el = $(this);
              
              //default color values
              localStorage.setItem('r','14');
      Severity: Major
      Found in src/components/shared/custom.js - About 2 hrs to fix

        Function uploadReducer has 47 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        const uploadReducer = (state = initState, action) => {
          switch (action.type) {
            case navigationActions.VISIT_UPLOAD_FORM:
              return initState; // resets state.
        
        
        Severity: Minor
        Found in src/redux/reducers/upload-reducer.tsx - About 1 hr to fix

          Function render has 44 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            render() {
              const { download, status } = this.props;
              const ICON_DOWNLOAD = require("../../assets/images/icon_download.png");
              return (
                <Slide title="Retrieve a File" image={ICON_DOWNLOAD}>
          Severity: Minor
          Found in src/components/download-form/download-form-slide.tsx - About 1 hr to fix

            Function streamUploadEpic has 43 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              action$.ofType(uploadActions.UPLOAD).mergeMap(action => {
                const {
                  file,
                  retentionYears,
                  brokers: { alpha, beta }
            Severity: Minor
            Found in src/redux/epics/upload-epic.tsx - About 1 hr to fix

              Function reducer has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              const reducer = (state = initState, action) => {
                switch (action.type) {
                  case uploadActions.PAYMENT_CONFIRMED: {
                    const { filename, handle, numberOfChunks } = action.payload;
                    const now = Date.now();
              Severity: Minor
              Found in src/redux/reducers/upload-history-reducer.tsx - About 1 hr to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                onChange={event => {
                                  let retentionYears = event.target.value;
                                  selectRetentionYears(retentionYears);
                                  this.setState({
                                    storageCost: this.calculateStorageCost(
                Severity: Major
                Found in src/components/upload-form/upload-slide.tsx and 1 other location - About 1 hr to fix
                src/components/upload-form/upload-slide.tsx on lines 118..127

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 69.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                                onChange={event => {
                                  let retentionYears = event.target.value;
                                  selectRetentionYears(retentionYears);
                                  this.setState({
                                    storageCost: this.calculateStorageCost(
                Severity: Major
                Found in src/components/upload-form/upload-slide.tsx and 1 other location - About 1 hr to fix
                src/components/upload-form/upload-slide.tsx on lines 135..144

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 69.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Avoid too many return statements within this function.
                Open

                      return { ...state, handle: handle, uploadProgress: 100 };
                Severity: Major
                Found in src/redux/reducers/upload-reducer.tsx - About 30 mins to fix
                  Severity
                  Category
                  Status
                  Source
                  Language