Sign upLogin

ozfortress/citadel

View on GitHub
Star
app/models/league/roster/transfer_request.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Class TransferRequest has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

    class TransferRequest < ApplicationRecord
      belongs_to :roster
      belongs_to :leaving_roster, class_name: 'Roster', optional: true

      belongs_to :user
Severity: Minor
Found in app/models/league/roster/transfer_request.rb - About 2 hrs to fix

    Method on_roster_check has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

          def on_roster_check
        return unless user.present? && roster.present?

        if roster.on_roster?(user)
          errors.add(:user_id, 'Is already on the roster') if is_joining?
    Severity: Minor
    Found in app/models/league/roster/transfer_request.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status