Sign upLogin

pagseguro/magento2

View on GitHub
Star
Model/Direct/CreditCardMethod.php

Summary

Maintainability
D
2 days
Test Coverage

CreditCardMethod has 35 functions (exceeds 20 allowed). Consider refactoring.
Open

class CreditCardMethod
{
    /**
     * @var \Magento\Checkout\Model\Session
     */
Severity: Minor
Found in Model/Direct/CreditCardMethod.php - About 4 hrs to fix

    File CreditCardMethod.php has 313 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
/**
 * 2007-2016 [PagSeguro Internet Ltda.]
 *
 * NOTICE OF LICENSE
    Severity: Minor
    Found in Model/Direct/CreditCardMethod.php - About 3 hrs to fix

      Method setShippingInformation has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private function setShippingInformation()
    {
        $shipping = $this->_order->getShippingAddress();
        if ($shipping) {
            if (count($shipping->getStreet()) === 4) {
      Severity: Minor
      Found in Model/Direct/CreditCardMethod.php - About 1 hr to fix

        Method setBillingInformation has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private function setBillingInformation()
    {
        $billing = $this->getBillingAddress();
        if ($billing) {
            if (count($billing->getStreet()) === 4) {
        Severity: Minor
        Found in Model/Direct/CreditCardMethod.php - About 1 hr to fix

          Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                  \Magento\Directory\Api\CountryInformationAcquirerInterface $countryInformation,
        \Magento\Framework\App\Config\ScopeConfigInterface $scopeConfigInterface,
        \Magento\Framework\Module\ModuleList $moduleList,
        \Magento\Sales\Model\Order $order,
        \UOL\PagSeguro\Helper\Library $library,
          Severity: Minor
          Found in Model/Direct/CreditCardMethod.php - About 45 mins to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                private function setShippingInformation()
    {
        $shipping = $this->_order->getShippingAddress();
        if ($shipping) {
            if (count($shipping->getStreet()) === 4) {
            Severity: Major
            Found in Model/Direct/CreditCardMethod.php and 2 other locations - About 1 day to fix
            Model/Direct/BoletoMethod.php on lines 298..332
            Model/Direct/DebitMethod.php on lines 304..338

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 319.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status