Sign upLogin

pagseguro/pagseguro-php-sdk

View on GitHub
Star

Showing 191 of 191 total issues

Similar blocks of code found in 5 locations. Consider refactoring.
Open

<?php
/**
 * 2007-2016 [PagSeguro Internet Ltda.]
 *
 * NOTICE OF LICENSE
Severity: Major
Found in source/Domains/Responses/Applications/Application.php and 4 other locations - About 1 hr to fix
source/Domains/DirectPayment/CreditCard/Installment.php on lines 1..70
source/Domains/Metadata.php on lines 1..78
source/Domains/PaymentMethod.php on lines 1..99
source/Domains/Permission.php on lines 1..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

<?php
/**
 * 2007-2016 [PagSeguro Internet Ltda.]
 *
 * NOTICE OF LICENSE
Severity: Major
Found in source/Domains/DirectPayment/CreditCard/Installment.php and 4 other locations - About 1 hr to fix
source/Domains/Metadata.php on lines 1..78
source/Domains/PaymentMethod.php on lines 1..99
source/Domains/Permission.php on lines 1..99
source/Domains/Responses/Applications/Application.php on lines 1..99

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 109.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getData has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getData(Requests $request, $properties)
    {
        $data = [];

        if ($request->metadataLenght() > 0) {
Severity: Minor
Found in source/Parsers/Metadata.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getData has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public static function getData(Requests $request, $properties)
    {
        $data = [];
        $paymentMethod = $request->getPaymentMethod();
        if ($request->paymentMethodLenght() > 0) {
Severity: Minor
Found in source/Parsers/PaymentMethod.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method checkout has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function checkout(Credentials $credentials, \PagSeguro\Domains\Requests\Payment $payment, $onlyCode)
    {
        Logger::info("Begin", ['service' => 'Checkout']);
        try {
            $connection = new Connection\Data($credentials);
Severity: Minor
Found in source/Services/Checkout/Payment.php - About 1 hr to fix

    Method search has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public static function search(
        Credentials $credentials,
        array $options
    )
    {
    Severity: Minor
    Found in source/Services/Transactions/Search/Date.php - About 1 hr to fix

      Method search has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public static function search(
        Credentials $credentials,
        $reference,
        array $options
    )
      Severity: Minor
      Found in source/Services/Transactions/Search/Reference.php - About 1 hr to fix

        Method search has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function search(
        Credentials $credentials,
        array $options
    )
    {
        Severity: Minor
        Found in source/Services/Transactions/Search/Abandoned.php - About 1 hr to fix

          Method checkout has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function checkout(
        Credentials $credentials,
        \PagSeguro\Domains\Requests\DirectPayment\Boleto $payment
    )
    {
          Severity: Minor
          Found in source/Services/DirectPayment/Boleto.php - About 1 hr to fix

            Method search has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function search(
        Credentials $credentials,
        $reference,
        array $options
    ) {
            Severity: Minor
            Found in source/Services/Application/Search/Reference.php - About 1 hr to fix

              Method checkout has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public static function checkout(
        Credentials $credentials,
        \PagSeguro\Domains\Requests\DirectPayment\OnlineDebit $payment
    )
    {
              Severity: Minor
              Found in source/Services/DirectPayment/OnlineDebit.php - About 1 hr to fix

                Method search has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public static function search(
        Credentials $credentials,
        array $options
    ) {
        try {
                Severity: Minor
                Found in source/Services/Application/Search/Date.php - About 1 hr to fix

                  Method create has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public static function create(Credentials $credentials, ChangePayment $changePayment)
    {
        Logger::info("Begin", ['service' => 'DirectPreApproval']);
        try {
            $connection = new Connection\Data($credentials);
                  Severity: Minor
                  Found in source/Services/DirectPreApproval/ChangePaymentService.php - About 1 hr to fix

                    Method edit has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public static function edit(Credentials $credentials, EditPlan $editPlan)
    {
        Logger::info("Begin", ['service' => 'DirectPreApproval']);
        try {
            $connection = new Connection\Data($credentials);
                    Severity: Minor
                    Found in source/Services/DirectPreApproval/EditPlanService.php - About 1 hr to fix

                      Method search has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public static function search(Credentials $credentials, $code)
    {
        Logger::info("Begin", ['service' => 'Transactions.Search.Code']);

        try {
                      Severity: Minor
                      Found in source/Services/Transactions/Search/Code.php - About 1 hr to fix

                        Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public static function create(Credentials $credentials, Cancel $cancel)
    {
        Logger::info("Begin", ['service' => 'DirectPreApproval']);
        try {
            $connection = new Connection\Data($credentials);
                        Severity: Minor
                        Found in source/Services/DirectPreApproval/CancelService.php - About 1 hr to fix

                          Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public static function create(Credentials $credentials, Status $status)
    {
        Logger::info("Begin", ['service' => 'DirectPreApproval']);
        try {
            $connection = new Connection\Data($credentials);
                          Severity: Minor
                          Found in source/Services/DirectPreApproval/StatusService.php - About 1 hr to fix

                            Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public static function create(Credentials $credentials, QueryNotification $queryNotification)
    {
        Logger::info("Begin", ['service' => 'DirectPreApproval']);
        try {
            $connection = new Connection\Data($credentials);
                            Severity: Minor
                            Found in source/Services/DirectPreApproval/QueryNotificationService.php - About 1 hr to fix

                              Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public static function create(Credentials $credentials, Discount $discount)
    {
        Logger::info("Begin", ['service' => 'DirectPreApproval']);
        try {
            $connection = new Connection\Data($credentials);
                              Severity: Minor
                              Found in source/Services/DirectPreApproval/DiscountService.php - About 1 hr to fix

                                Method create has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    public static function create(Credentials $credentials, RetryPaymentOrder $retryPaymentOrder)
    {
        Logger::info("Begin", ['service' => 'DirectPreApproval']);
        try {
            $connection = new Connection\Data($credentials);
                                Severity: Minor
                                Found in source/Services/DirectPreApproval/RetryPaymentOrderService.php - About 1 hr to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language