Sign upLogin

palicao/phpRebloom

View on GitHub
Star

Showing 9 of 9 total issues

Method connectIfNeeded has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function connectIfNeeded(): void
    {
        if ($this->redis->isConnected()) {
            return;
        }
Severity: Minor
Found in src/RedisClient.php - About 1 hr to fix

    Method __construct has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            string $key,
        int $size,
        int $numBuckets,
        int $numFilters,
        int $insertedItems,
    Severity: Major
    Found in src/CuckooFilterInfo.php - About 1 hr to fix

      Function insertMany has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function insertMany(string $key, array $values, ?float $error = null, ?int $capacity = null): array
    {
        $count = count($values);
        if ($count === 0) {
            return [];
      Severity: Minor
      Found in src/BloomFilter.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method reserve has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function reserve(string $key, int $capacity, ?int $bucketSize = null, ?int $maxIterations = null, ?int $expansion = null): bool
      Severity: Minor
      Found in src/CuckooFilter.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public function __construct(string $key, int $topK, int $width, int $depth, float $decay)
        Severity: Minor
        Found in src/TopKInfo.php - About 35 mins to fix

          Method doInsert has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function doInsert(string $key, array $values, bool $allowDuplicateValues, bool $createKey, ?int $capacity): array
          Severity: Minor
          Found in src/CuckooFilter.php - About 35 mins to fix

            Method reserve has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function reserve(string $key, int $topK, int $width, int $depth, float $decay): bool
            Severity: Minor
            Found in src/TopK.php - About 35 mins to fix

              Function authenticate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function authenticate(?string $username, ?string $password): void
    {
        try {
            if ($password) {
                if ($username) {
              Severity: Minor
              Found in src/RedisClient.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function doInsert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function doInsert(string $key, array $values, bool $allowDuplicateValues, bool $createKey, ?int $capacity): array
    {
        $affix = $allowDuplicateValues ? '' : 'NX';

        $count = count($values);
              Severity: Minor
              Found in src/CuckooFilter.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language