Sign upLogin

palmerj3/DW4

View on GitHub
Star

Showing 3 of 3 total issues

Function tick has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

Player.prototype.tick = function() {
  var currentTime = (new Date()).getTime();

  if (currentTime - this.state.lastTick > 250 || this.state.directionChanged === true) {
    this.state.currentModel = this.models[this.state.direction + '-' + this.state.modelState];
Severity: Minor
Found in components/character/player/index.js - About 1 hr to fix

    Function listenForUserInput has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        listenForUserInput : function() {
      var self = this;

      // var lazyKeydown = _.throttle(function(e) {
      //   var direction = '';
    Severity: Minor
    Found in components/app.js - About 1 hr to fix

      Function tick has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

      Player.prototype.tick = function() {
  var currentTime = (new Date()).getTime();

  if (currentTime - this.state.lastTick > 250 || this.state.directionChanged === true) {
    this.state.currentModel = this.models[this.state.direction + '-' + this.state.modelState];
      Severity: Minor
      Found in components/character/player/index.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language