pankod/refine

View on GitHub

Showing 959 of 983 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  React.useEffect(() => {
    if (initiallySynced === false && syncWithLocationKey) {
      const openStatus = parsed?.params?.[syncWithLocationKey]?.open;
      if (typeof openStatus === "boolean") {
        if (openStatus) {
Severity: Major
Found in packages/react-hook-form/src/useModalForm/index.ts and 2 other locations - About 6 hrs to fix
packages/antd/src/hooks/form/useModalForm/useModalForm.ts on lines 208..231
packages/mantine/src/hooks/form/useModalForm/index.ts on lines 181..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

  React.useEffect(() => {
    if (initiallySynced === false && syncWithLocationKey) {
      const openStatus = parsed?.params?.[syncWithLocationKey]?.open;
      if (typeof openStatus === "boolean") {
        if (openStatus) {
Severity: Major
Found in packages/mantine/src/hooks/form/useModalForm/index.ts and 2 other locations - About 6 hrs to fix
packages/antd/src/hooks/form/useModalForm/useModalForm.ts on lines 208..231
packages/react-hook-form/src/useModalForm/index.ts on lines 181..203

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  const renderedFields: Array<string | undefined> = fields.map((field) => {
    switch (field?.type) {
      case "url":
      case "text":
      case "email":
Severity: Major
Found in packages/inferencer/src/inferencers/mantine/edit.tsx and 1 other location - About 6 hrs to fix
packages/inferencer/src/inferencers/mantine/create.tsx on lines 315..336

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

  const renderedFields: Array<string | undefined> = fields.map((field) => {
    switch (field?.type) {
      case "url":
      case "text":
      case "email":
Severity: Major
Found in packages/inferencer/src/inferencers/mantine/create.tsx and 1 other location - About 6 hrs to fix
packages/inferencer/src/inferencers/mantine/edit.tsx on lines 401..422

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

export const metaFieldsToGqlFields = (metaFields: MetaQuery["fields"]) => {
  if (!metaFields) return "";

  const fields: string[] = [];

Severity: Major
Found in packages/graphql/src/utils/graphql.ts and 1 other location - About 6 hrs to fix
packages/hasura/src/utils/graphql.ts on lines 79..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

export const metaFieldsToGqlFields = (metaFields: MetaQuery["fields"]) => {
  if (!metaFields) return "";

  const fields: string[] = [];

Severity: Major
Found in packages/hasura/src/utils/graphql.ts and 1 other location - About 6 hrs to fix
packages/graphql/src/utils/graphql.ts on lines 79..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 157.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Sider has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

export const Sider: React.FC<RefineLayoutSiderProps> = ({
  Title: TitleFromProps,
  render,
  meta,
}) => {
Severity: Minor
Found in packages/chakra-ui/src/components/layout/sider/index.tsx - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function useNotificationProvider has 148 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const useNotificationProvider = (): NotificationProvider => {
  const activeNotifications: string[] = [];

  const isNotificationActive = (key?: string) => {
    return activeNotifications.includes(key as string);
Severity: Major
Found in packages/mantine/src/providers/notificationProvider.tsx - About 5 hrs to fix

    Function useRegister has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
    Open

    export function useRegister<TVariables = {}>({
      v3LegacyAuthProviderCompatible,
      mutationOptions,
    }: UseRegisterProps<TVariables> | UseRegisterLegacyProps<TVariables> = {}):
      | UseRegisterReturnType<TVariables>
    Severity: Minor
    Found in packages/core/src/hooks/auth/useRegister/index.ts - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function checkPackage has 147 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const checkPackage = (code = "") => {
      const set = new Set<string>();
    
      const hasAntd =
        code.includes("@refinedev/antd") ||
    Severity: Major
    Found in packages/live-previews/src/utils/check-package.ts - About 5 hrs to fix

      Function fixDeprecatedUseTableProps has 146 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const fixDeprecatedUseTableProps = (j: JSCodeshift, source: Collection) => {
        const willCheckImports = ["useTable", "useDataGrid"];
      
        willCheckImports.forEach((hook) => {
          const useTableHooks = source.find(j.CallExpression, {
      Severity: Major
      Found in packages/codemod/src/transformations/v4/fix-v4-deprecations.ts - About 5 hrs to fix

        Function Edit has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
        Open

        export const Edit: React.FC<EditProps> = ({
          title,
          saveButtonProps: saveButtonPropsFromProps,
          mutationMode: mutationModeProp,
          recordItemId,
        Severity: Minor
        Found in packages/antd/src/components/crud/edit/index.tsx - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function useTable has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
        Open

        export const useTable = <
          TQueryFnData extends BaseRecord = BaseRecord,
          TError extends HttpError = HttpError,
          TSearchVariables = unknown,
          TData extends BaseRecord = TQueryFnData,
        Severity: Minor
        Found in packages/antd/src/hooks/table/useTable/useTable.ts - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function DataProvider has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
        Open

        export const DataProvider = (
          apiUrl: string,
          httpClient: AxiosInstance = axiosInstance,
        ): Required<IDataProvider> => ({
          getList: async ({ resource, pagination, filters, sorters, meta }) => {
        Severity: Minor
        Found in packages/strapi-v4/src/dataProvider.ts - About 5 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function renderTreeView has 143 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          const renderTreeView = (tree: ITreeMenu[], selectedKey?: string) => {
            return tree.map((item: ITreeMenu) => {
              const { icon, label, route, name, children, parentName, meta, options } =
                item;
              const isOpen = open[item.key || ""] || false;
        Severity: Major
        Found in packages/mui/src/components/themedLayoutV2/sider/index.tsx - About 5 hrs to fix

          Function renderTreeView has 141 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            const renderTreeView = (tree: ITreeMenu[], selectedKey?: string) => {
              return tree.map((item: ITreeMenu) => {
                const { icon, label, route, name, children, parentName, meta, options } =
                  item;
                const isOpen = open[item.key || ""] || false;
          Severity: Major
          Found in packages/mui/src/components/themedLayout/sider/index.tsx - About 5 hrs to fix

            Function DataProvider has 140 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            const DataProvider = (
              apiUrl: string,
              httpClient: AxiosInstance = axiosInstance,
            ): Required<DataProviderType> => {
              return {
            Severity: Major
            Found in packages/medusa/src/dataProvider/index.ts - About 5 hrs to fix

              Function ConfigSuccessPage has 140 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              export const ConfigSuccessPage: React.FC = () => {
                const isTablet = useMediaQuery("(max-width: 1010px)");
                const isMobile = useMediaQuery("(max-width: 650px)");
              
                const getGridTemplateColumns = () => {
              Severity: Major
              Found in packages/core/src/components/pages/config-success/index.tsx - About 5 hrs to fix

                Function Show has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
                Open

                export const Show: React.FC<ShowProps> = ({
                  title,
                  canEdit,
                  canDelete,
                  isLoading = false,
                Severity: Minor
                Found in packages/antd/src/components/crud/show/index.tsx - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Function useLogout has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
                Open

                export function useLogout<TVariables = {}>({
                  v3LegacyAuthProviderCompatible,
                  mutationOptions,
                }: UseLogoutProps<TVariables> | UseLogoutLegacyProps<TVariables> = {}):
                  | UseLogoutLegacyReturnType<TVariables>
                Severity: Minor
                Found in packages/core/src/hooks/auth/useLogout/index.ts - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language