Sign upLogin

pankod/refine

View on GitHub
Star
packages/react-hook-form/src/useModalForm/index.ts

Summary

Maintainability
D
2 days
Test Coverage

Function useModalForm has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

export const useModalForm = <
  TQueryFnData extends BaseRecord = BaseRecord,
  TError extends HttpError = HttpError,
  TVariables extends FieldValues = FieldValues,
  TContext extends object = {},
Severity: Minor
Found in packages/react-hook-form/src/useModalForm/index.ts - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handleClose has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const handleClose = useCallback(() => {
    if (
      autoSaveProps.status === "success" &&
      refineCoreProps?.autoSave?.invalidateOnClose
    ) {
Severity: Minor
Found in packages/react-hook-form/src/useModalForm/index.ts - About 1 hr to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

      React.useEffect(() => {
    if (initiallySynced === false && syncWithLocationKey) {
      const openStatus = parsed?.params?.[syncWithLocationKey]?.open;
      if (typeof openStatus === "boolean") {
        if (openStatus) {
    Severity: Major
    Found in packages/react-hook-form/src/useModalForm/index.ts and 2 other locations - About 6 hrs to fix
    packages/antd/src/hooks/form/useModalForm/useModalForm.ts on lines 208..231
    packages/mantine/src/hooks/form/useModalForm/index.ts on lines 181..203

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 160.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 9 locations. Consider refactoring.
    Open

    export type UseModalFormReturnType<
  TQueryFnData extends BaseRecord = BaseRecord,
  TError extends HttpError = HttpError,
  TVariables extends FieldValues = FieldValues,
  TContext extends object = {},
    Severity: Major
    Found in packages/react-hook-form/src/useModalForm/index.ts and 8 other locations - About 1 hr to fix
    packages/react-hook-form/src/useForm/index.ts on lines 25..46
    packages/react-hook-form/src/useForm/index.ts on lines 48..80
    packages/react-hook-form/src/useForm/index.ts on lines 82..274
    packages/react-hook-form/src/useModalForm/index.ts on lines 47..83
    packages/react-hook-form/src/useModalForm/index.ts on lines 85..318
    packages/react-hook-form/src/useStepsForm/index.ts on lines 8..29
    packages/react-hook-form/src/useStepsForm/index.ts on lines 31..63
    packages/react-hook-form/src/useStepsForm/index.ts on lines 65..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 9 locations. Consider refactoring.
    Open

    export const useModalForm = <
  TQueryFnData extends BaseRecord = BaseRecord,
  TError extends HttpError = HttpError,
  TVariables extends FieldValues = FieldValues,
  TContext extends object = {},
    Severity: Major
    Found in packages/react-hook-form/src/useModalForm/index.ts and 8 other locations - About 1 hr to fix
    packages/react-hook-form/src/useForm/index.ts on lines 25..46
    packages/react-hook-form/src/useForm/index.ts on lines 48..80
    packages/react-hook-form/src/useForm/index.ts on lines 82..274
    packages/react-hook-form/src/useModalForm/index.ts on lines 21..45
    packages/react-hook-form/src/useModalForm/index.ts on lines 47..83
    packages/react-hook-form/src/useStepsForm/index.ts on lines 8..29
    packages/react-hook-form/src/useStepsForm/index.ts on lines 31..63
    packages/react-hook-form/src/useStepsForm/index.ts on lines 65..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 9 locations. Consider refactoring.
    Open

    export type UseModalFormProps<
  TQueryFnData extends BaseRecord = BaseRecord,
  TError extends HttpError = HttpError,
  TVariables extends FieldValues = FieldValues,
  TContext extends object = {},
    Severity: Major
    Found in packages/react-hook-form/src/useModalForm/index.ts and 8 other locations - About 1 hr to fix
    packages/react-hook-form/src/useForm/index.ts on lines 25..46
    packages/react-hook-form/src/useForm/index.ts on lines 48..80
    packages/react-hook-form/src/useForm/index.ts on lines 82..274
    packages/react-hook-form/src/useModalForm/index.ts on lines 21..45
    packages/react-hook-form/src/useModalForm/index.ts on lines 85..318
    packages/react-hook-form/src/useStepsForm/index.ts on lines 8..29
    packages/react-hook-form/src/useStepsForm/index.ts on lines 31..63
    packages/react-hook-form/src/useStepsForm/index.ts on lines 65..172

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

      const syncWithLocationKey =
    typeof syncWithLocation === "object" && "key" in syncWithLocation
      ? syncWithLocation.key
      : resource && action && syncWithLocation
        ? `modal-${identifier}-${action}`
    Severity: Major
    Found in packages/react-hook-form/src/useModalForm/index.ts and 2 other locations - About 1 hr to fix
    packages/antd/src/hooks/form/useModalForm/useModalForm.ts on lines 153..158
    packages/mantine/src/hooks/form/useModalForm/index.ts on lines 144..149

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 58.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status