Sign upLogin

paradite/gitviz

View on GitHub
Star
public/js/data.js

Summary

Maintainability
F
3 days
Test Coverage

Function data has 293 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var data = (function() {
  var API_BASE_URL = 'https://api.github.com';
  var API_USER = '/users/';
  var API_PUBLIC_EVENTS = '/events/public';
  var API_ORG = '/orgs/';
Severity: Major
Found in public/js/data.js - About 1 day to fix

    Function data has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring.
    Open

    var data = (function() {
  var API_BASE_URL = 'https://api.github.com';
  var API_USER = '/users/';
  var API_PUBLIC_EVENTS = '/events/public';
  var API_ORG = '/orgs/';
    Severity: Minor
    Found in public/js/data.js - About 7 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File data.js has 297 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    var async = require('./vendor/async.min');

// Data manipulation logic
var data = (function() {
  var API_BASE_URL = 'https://api.github.com';
    Severity: Minor
    Found in public/js/data.js - About 3 hrs to fix

      Function getPubEvent has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        module.getPubEvent = function(user, cb) {
    var url = API_BASE_URL + API_USER + user.username + API_PUBLIC_EVENTS;
    var userDetailUrl = API_BASE_URL + API_USER + user.username;

    async.parallel([
      Severity: Minor
      Found in public/js/data.js - About 1 hr to fix

        Function _handleCommitDetail has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          var _handleCommitDetail = function(user, cb, err, res, repo) {
        Severity: Minor
        Found in public/js/data.js - About 35 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            var _getRepoCommits = function(username, repo, cb) {
    var url = API_REPO + '/' + username + '/' + repo + API_REPO_COMMITS;
    d3.json(_useBackend(url))
      .get(function(err, data) {
        if (err) {
          Severity: Major
          Found in public/js/data.js and 1 other location - About 3 hrs to fix
          public/js/data.js on lines 30..40

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            module.getContribution = function(username, repo, cb) {
    var url = API_REPO + '/' + username + '/' + repo + API_REPO_CONTRIBUTOR;
    d3.json(_useBackend(url))
      .get(function(err, data) {
        if (err) {
          Severity: Major
          Found in public/js/data.js and 1 other location - About 3 hrs to fix
          public/js/data.js on lines 42..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 95.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Unexpected literal in error position of callback.
          Open

                cb('User does not exist or have empty commits', null, null);
          Severity: Minor
          Found in public/js/data.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          Unexpected literal in error position of callback.
          Open

                  cb('There is no GitHub public email for ' + user.username + ', please enter mannually', null, null);
          Severity: Minor
          Found in public/js/data.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          Unexpected literal in error position of callback.
          Open

                  cb('GitHub API error', null, null);
          Severity: Minor
          Found in public/js/data.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          There are no issues that match your filters.

          Category
          Status