Showing 365 of 365 total issues
Function data
has 293 lines of code (exceeds 25 allowed). Consider refactoring. Open
var data = (function() {
var API_BASE_URL = 'https://api.github.com';
var API_USER = '/users/';
var API_PUBLIC_EVENTS = '/events/public';
var API_ORG = '/orgs/';
Function calendarHeatmap
has 262 lines of code (exceeds 25 allowed). Consider refactoring. Open
function calendarHeatmap() {
// defaults
var width = 750;
var height = 110;
var legendWidth = 125;
Function calendarHeatmap
has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring. Open
function calendarHeatmap() {
// defaults
var width = 750;
var height = 110;
var legendWidth = 125;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function chart
has 191 lines of code (exceeds 25 allowed). Consider refactoring. Open
var chart = (function() {
var _chartElement = null;
var _svgWrapper = null;
var _xAxisElement = null;
var _brushAxisElement = null;
Function data
has a Cognitive Complexity of 49 (exceeds 5 allowed). Consider refactoring. Open
var data = (function() {
var API_BASE_URL = 'https://api.github.com';
var API_USER = '/users/';
var API_PUBLIC_EVENTS = '/events/public';
var API_ORG = '/orgs/';
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function chart
has 176 lines of code (exceeds 25 allowed). Consider refactoring. Open
function chart() {
d3.select(chart.selector()).selectAll('svg.calendar-heatmap').remove(); // remove the existing chart, if it exists
if(!chart.dateRange()) {
dateRange = d3.time.days(yearAgo, now); // generates an array of date objects within the specified range
}
Function drawChart
has 123 lines of code (exceeds 25 allowed). Consider refactoring. Open
function drawChart() {
var svg = d3.select(chart.selector())
.append('svg')
.attr('width', width)
.attr('class', 'calendar-heatmap')
File controller-3219-2.js
has 350 lines of code (exceeds 250 allowed). Consider refactoring. Open
d3.tip = require('./vendor/d3-tip');
var outstandingCommits;
var chartData = {};
Identical blocks of code found in 2 locations. Consider refactoring. Open
function addNewUser(user) {
if (user === null) {
return;
}
viz.ui.showSpinner();
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 108.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
circleChart.addNewUser = function(user) {
if (user === null) {
return;
}
viz.ui.showSpinner();
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 108.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
File data.js
has 297 lines of code (exceeds 250 allowed). Consider refactoring. Open
var async = require('./vendor/async.min');
// Data manipulation logic
var data = (function() {
var API_BASE_URL = 'https://api.github.com';
Function chart
has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring. Open
var chart = (function() {
var _chartElement = null;
var _svgWrapper = null;
var _xAxisElement = null;
var _brushAxisElement = null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Similar blocks of code found in 2 locations. Consider refactoring. Open
var _getRepoCommits = function(username, repo, cb) {
var url = API_REPO + '/' + username + '/' + repo + API_REPO_COMMITS;
d3.json(_useBackend(url))
.get(function(err, data) {
if (err) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 95.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
module.getContribution = function(username, repo, cb) {
var url = API_REPO + '/' + username + '/' + repo + API_REPO_CONTRIBUTOR;
d3.json(_useBackend(url))
.get(function(err, data) {
if (err) {
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 95.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function includes
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
Array.prototype.includes = function(searchElement /*, fromIndex*/ ) {
'use strict';
var O = Object(this);
var len = parseInt(O.length) || 0;
if (len === 0) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function handleNewContribution
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
function handleNewContribution(data) {
data = filterImportant(data.map(donutChart.type));
// Label in the center
donutChart.svg.select('.donut-label')
Function login
has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports.login = function (req, email, password, done) {
var params = {
"TableName": tableName,
"IndexName": "email-index",
"KeyConditions": {
Function getPubEvent
has 40 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.getPubEvent = function(user, cb) {
var url = API_BASE_URL + API_USER + user.username + API_PUBLIC_EVENTS;
var userDetailUrl = API_BASE_URL + API_USER + user.username;
async.parallel([
Function subscribe
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports.subscribe = function (emails, user) {
console.log("user email: ", user.email.S);
var params = {
"TableName": tableName,
"IndexName": "email-index",
Function createUser
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
module.exports.createUser = function (req, email, password, done) {
var params = {
"TableName": tableName,
"IndexName": "email-index",
"KeyConditions": {