Sign upLogin

partkeepr/PartKeepr

View on GitHub
Star

Showing 922 of 922 total issues

Function updateMenuItems has 61 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    updateMenuItems: function (loadedState, records)
    {

        for (var i = 0; i < this.storeMenus.length; i++)
        {
Severity: Major
Found in src/PartKeepr/FrontendBundle/Resources/public/js/Ext.ux/StoreMenu.js - About 2 hrs to fix

    Function SIUnitPrefix has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        SIUnitPrefix: function( q_value, q_unit )
    {
        // the new Octopart API returns quantities as display strings: e.g. "12 mm"
        // try to recognize SI-unit and SI-prefix
    Severity: Minor
    Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/OctoPart/DataApplicator.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onItemSave has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        onItemSave: function ()
    {
        var removeRecords = [], j, errors = [],
            minDistributorCount = PartKeepr.getApplication().getSystemPreference(
                "partkeepr.part.constraints.distributorCount", 0),
    Severity: Minor
    Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartEditor.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function onStartEdit has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        onStartEdit: function ()
    {
        if (this.record.get("protected") === true) {
            this.items.each(function (item) {
                if (item instanceof Ext.form.field.Base && !(item instanceof Ext.form.field.Display)) {
    Severity: Minor
    Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/User/UserEditor.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function extractJSONFilters has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        private function extractJSONFilters(
        $data
    ) {
        $filter = new Filter();
    Severity: Minor
    Found in src/PartKeepr/DoctrineReflectionBundle/Filter/AdvancedSearchFilter.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getFieldType has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        getFieldType: function (fieldName)
    {
        var ret = null, role, tmp, i;

        for (i=0;i<this.fields.length;i++) {
    Severity: Minor
    Found in src/PartKeepr/FrontendBundle/Resources/public/js/Data/HydraModel.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function authenticate has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function authenticate(TokenInterface $token)
    {
        $lastException = null;
        $result = null;
    Severity: Minor
    Found in src/PartKeepr/AuthBundle/Security/Authentication/AuthenticationProviderManager.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function enterNode has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function enterNode(\PHPParser_Node $node)
    {
        if ($node instanceof \PHPParser_Node_Expr_MethodCall) {
            if ($node->var->name == 'container' && $node->name == 'setParameter') {
                if (array_key_exists(0, $node->args) && array_key_exists(1, $node->args)) {
    Severity: Minor
    Found in src/PartKeepr/SetupBundle/Visitor/ConfigVisitor.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function validateConfigNode has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        validateConfigNode: function (node)
    {
        var configuration = node.data.data.configuration;
        var recurse = false;
    Severity: Major
    Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Importer/Importer.js - About 2 hrs to fix

      Method import has 60 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function import($row, $obj = null)
    {
        $descriptions = [];
        switch ($this->importBehaviour) {
            case self::IMPORTBEHAVIOUR_ALWAYSIMPORT:
      Severity: Major
      Found in src/PartKeepr/ImportBundle/Configuration/EntityConfiguration.php - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    tooltip: {
                trackMouse: true,
                renderer: function (tip, item)
                {
                    tip.update(Ext.Date.format(item.get('start'), "Y-m-d") + ": " + item.get(
        Severity: Major
        Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Statistics/StatisticsChart.js and 1 other location - About 2 hrs to fix
        src/PartKeepr/FrontendBundle/Resources/public/js/Components/Statistics/StatisticsChart.js on lines 27..35

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    tooltip: {
                trackMouse: true,
                renderer: function (tip, item)
                {
                    tip.update(
        Severity: Major
        Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Statistics/StatisticsChart.js and 1 other location - About 2 hrs to fix
        src/PartKeepr/FrontendBundle/Resources/public/js/Components/Statistics/StatisticsChart.js on lines 55..62

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 83.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function createToolbar has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            createToolbar: function ()
    {
        this.toolbarExpandButton = Ext.create("Ext.button.Button", {
            iconCls: 'fugue-icon toggle-expand',
            tooltip: i18n("Expand All"),
        Severity: Major
        Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/CategoryEditor/CategoryEditorTree.js - About 2 hrs to fix

          Function getEditingContext has 59 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              getEditingContext: function (record, columnHeader)
    {
        var me = this,
            grid = me.grid,
            colMgr = grid.visibleColumnManager,
          Severity: Major
          Found in src/PartKeepr/FrontendBundle/Resources/public/js/ExtJS/Enhancements/Ext.grid.plugin.Editing-associationSupport.js - About 2 hrs to fix

            Function getAssociatedStore has 59 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                getAssociatedStore: function (inverseRecord, options, scope, records, isComplete) {
        // Consider the Comment entity with a ticketId to a Ticket entity. The Comment
        // is on the left (the FK holder's side) so we are implementing the guts of
        // the comments() method to load the Store of Comment entities. This trek
        // begins from a Ticket (inverseRecord).
            Severity: Major
            Found in src/PartKeepr/FrontendBundle/Resources/public/js/ExtJS/Bugfixes/Ext.data.Model-EXTJS-15037.js - About 2 hrs to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              Ext.define('PartKeepr.ManufacturerGrid', {
    extend: 'PartKeepr.EditorGrid',
    alias: 'widget.ManufacturerGrid',
    columns: [
        {header: i18n("Manufacturer"), dataIndex: 'name', flex: 1}
              Severity: Major
              Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Manufacturer/ManufacturerGrid.js and 1 other location - About 2 hrs to fix
              src/PartKeepr/FrontendBundle/Resources/public/js/Components/Project/ProjectGrid.js on lines 4..15

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

              Ext.define('PartKeepr.ProjectGrid', {
    extend: 'PartKeepr.EditorGrid',
    alias: 'widget.ProjectGrid',
    columns: [
        {header: i18n("Project"), dataIndex: 'name', flex: 1}
              Severity: Major
              Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Project/ProjectGrid.js and 1 other location - About 2 hrs to fix
              src/PartKeepr/FrontendBundle/Resources/public/js/Components/Manufacturer/ManufacturerGrid.js on lines 1..12

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 82.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              File AdvancedSearchFilter.php has 263 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              <?php

namespace PartKeepr\DoctrineReflectionBundle\Filter;

use Doctrine\Common\Persistence\ManagerRegistry;
              Severity: Minor
              Found in src/PartKeepr/DoctrineReflectionBundle/Filter/AdvancedSearchFilter.php - About 2 hrs to fix

                Function initComponent has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    initComponent: function ()
    {
        var i;

        this.callParent(arguments);
                Severity: Major
                Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/BatchJob/BatchJobExecutionWindow.js - About 2 hrs to fix

                  Function initComponent has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      initComponent: function ()
    {

        this.editing = Ext.create('Ext.grid.plugin.CellEditing', {
            clicksToEdit: 1
                  Severity: Major
                  Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Project/ProjectPartGrid.js - About 2 hrs to fix
                    Severity
                    Category
                    Status
                    Source
                    Language