Sign upLogin

partkeepr/PartKeepr

View on GitHub
Star

Showing 922 of 922 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                    if (field.getValue()) {
                        this.port.disable();
                        this.port.setValue(3306);
                    } else {
                        this.port.enable();
Severity: Major
Found in web/setup/js/Cards/DatabaseParametersCard.MySQL.js and 1 other location - About 1 hr to fix
web/setup/js/Cards/DatabaseParametersCard.PostgreSQL.js on lines 96..103

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    addPartStockPrompt: function ()
    {
        var j = new PartKeepr.PartStockWindow({partUnitName: this.record.get("partUnitName")});
        j.addStock(this.addStockHandler, this);
    },
Severity: Major
Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartDisplay.js and 1 other location - About 1 hr to fix
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartDisplay.js on lines 168..172

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 61.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function onBeforeEdit has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    onBeforeEdit: function (editor, context, eOpts) {
        var sameUser = false;

        // Checks if the usernames match
        if (context.record.getUser() !== null) {
Severity: Minor
Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/StockReport/AbstractStockHistoryGrid.js - About 1 hr to fix

    Function getAccordion has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        getAccordion: function () {
        var tree = Ext.create('Ext.tree.Panel', {
            title: 'TreePanel',
            root: {
                text: 'Root Node',
    Severity: Minor
    Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/ThemeTester/ThemeTester.js - About 1 hr to fix

      Function onParameterSelect has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          onParameterSelect: function (combo, value)
    {
        var prefixes, j, unitFilter = [];

        this.valueType = value.get("valueType");
      Severity: Minor
      Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Widgets/PartParameterSearch.js - About 1 hr to fix

        Function getColumnConfigurations has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getColumnConfigurations: function ()
    {
        var i, j, rtype;

        var config = {}, columnConfigurations = [], fieldsToCopy = this.getFieldsToCopy();
        Severity: Minor
        Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Widgets/ColumnConfigurator/Panel.js - About 1 hr to fix

          Function removeStocks has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              removeStocks: function (btn)
    {
        if (btn === "yes")
        {
          Severity: Minor
          Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Project/ProjectReportResultGrid.js - About 1 hr to fix

            Function updateRecord has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                updateRecord: function(record) {
        record = record || this._record;
        if (!record) {
            //<debug>
            Ext.raise("A record is required.");
            Severity: Minor
            Found in src/PartKeepr/FrontendBundle/Resources/public/js/ExtJS/Enhancements/Ext.form.Basic-AssociationSupport.js - About 1 hr to fix

              Method fixTree has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function fixTree($table)
    {
        $nodes = $this->getNodeIds($table);

        $queryBuilder = $this->entityManager->getConnection()->createQueryBuilder();
              Severity: Minor
              Found in src/PartKeepr/CoreBundle/Command/FixTreeCommand.php - About 1 hr to fix

                Method fixTree has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function fixTree($table)
    {
        $nodes = $this->getNodeIds($table);

        $queryBuilder = $this->connection->createQueryBuilder();
                Severity: Minor
                Found in src/PartKeepr/CoreBundle/DoctrineMigrations/Version20150708120022.php - About 1 hr to fix

                  Function initComponent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      initComponent: function ()
    {
        var modifierItems = [
            {
                xtype: 'checkbox',
                  Severity: Minor
                  Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/SystemPreferences/Preferences/BarcodeScannerConfiguration.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getColumnConfigurations has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      getColumnConfigurations: function ()
    {
        var i, j, rtype;

        var config = {}, columnConfigurations = [], fieldsToCopy = this.getFieldsToCopy();
                  Severity: Minor
                  Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Widgets/ColumnConfigurator/Panel.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getProjectParts has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      getProjectParts: function (rec) {
        var report = rec.getReport(),
            i, j, project, projectPart, projectPartQuantities = [];

        for (i = 0; i < report.reportProjects().getCount(); i++)
                  Severity: Minor
                  Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Project/Renderers/RemarksRenderer.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function initComponent has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      initComponent: function ()
    {
        var i, rendererDef, rendererClass;

        if (this.$className !== "Ext.grid.column.Column") {
                  Severity: Minor
                  Found in src/PartKeepr/FrontendBundle/Resources/public/js/ExtJS/Enhancements/Ext.grid.Column-multipleRendererSupport.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function readAssociated has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      readAssociated: function(record, data, readOptions) {
        var roles = record.associations,
            key, role;

        for (key in roles) {
                  Severity: Minor
                  Found in src/PartKeepr/FrontendBundle/Resources/public/js/Data/HydraReader.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function onSuccess has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      onSuccess: function (response)
    {
        var obj;

        try {
                  Severity: Minor
                  Found in web/setup/js/SetupTests/AbstractTest.js - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function intMigrateFilesAction has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function intMigrateFilesAction(Request $request)
    {
        if (!$this->ensureAuthKey($request)) {
            return $this->getAuthKeyErrorResponse();
        }
                  Severity: Minor
                  Found in src/PartKeepr/SetupBundle/Controller/FileMigrationController.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function getRelease has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public function getRelease()
    {
        switch (strtolower($this->getPlatform())) {
            case 'freebsd':
                /*
                  Severity: Minor
                  Found in src/PartKeepr/CoreBundle/System/OperatingSystem.php - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      getImporterConfig: function ()
    {
        var config = this.getForm().getFieldValues();

        config.matchers = this.down("#importFieldMatcherGrid").getImporterConfig();
                  Severity: Major
                  Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Importer/ImporterEntityConfiguration.js and 1 other location - About 1 hr to fix
                  src/PartKeepr/FrontendBundle/Resources/public/js/Components/Importer/ImporterManyToOneConfiguration.js on lines 332..338

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      getImporterConfig: function ()
    {
        var config = this.getForm().getFieldValues();

        config.matchers = this.down("#importFieldMatcherGrid").getImporterConfig();
                  Severity: Major
                  Found in src/PartKeepr/FrontendBundle/Resources/public/js/Components/Importer/ImporterManyToOneConfiguration.js and 1 other location - About 1 hr to fix
                  src/PartKeepr/FrontendBundle/Resources/public/js/Components/Importer/ImporterEntityConfiguration.js on lines 94..100

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Severity
                  Category
                  Status
                  Source
                  Language