partkeepr/PartKeepr

View on GitHub

Showing 922 of 922 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    items: [{
        xtype: 'textfield',
        name: 'name',
        fieldLabel: i18n("Measurement Unit Name")
    },{
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Widgets/ColumnConfigurator/RendererConfigurationForm.js on lines 10..18
src/PartKeepr/MobileFrontendBundle/Resources/public/js/Components/Auth/LoginDialog.js on lines 27..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        this.store = Ext.create("Ext.data.Store", {
            model: 'PartKeepr.PartBundle.Entity.PartParameter',
            proxy: {
                type: 'memory',
                reader: {
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartDistributorGrid.js on lines 11..20
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/Editor/PartManufacturerGrid.js on lines 11..20

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for (i = 0; i < batchJobUpdateFields.getCount(); i++) {
            batchJobUpdateFields.getAt(i).set("value", "");
        }
src/PartKeepr/FrontendBundle/Resources/public/js/Components/BatchJob/BatchJobExecutionWindow.js on lines 95..97

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (this.dragAndDrop) {
            gridConfig.viewConfig = {
                plugins: {
                    ddGroup: 'StorageLocationTree',
                    ptype: 'gridviewdragdrop',
src/PartKeepr/FrontendBundle/Resources/public/js/Components/Part/PartsManager.js on lines 83..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 48.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace PartKeepr\CoreBundle\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
Severity: Minor
Found in src/PartKeepr/CoreBundle/Command/CheckForUpdatesCommand.php and 1 other location - About 40 mins to fix
src/PartKeepr/StatisticBundle/Command/CreateStatisticSnapshotCommand.php on lines 1..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

<?php

namespace PartKeepr\StatisticBundle\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
src/PartKeepr/CoreBundle/Command/CheckForUpdatesCommand.php on lines 1..23

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                foreach ($this->matchers as $matcher) {
                    $foo = new \stdClass();
                    $foo->property = $matcher->matchField;
                    $foo->operator = "=";
                    $foo->value = $row[$matcher->importField];
src/PartKeepr/ImportBundle/Configuration/EntityConfiguration.php on lines 93..101

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

                foreach ($this->matchers as $matcher) {
                    $foo = new \stdClass();
                    $foo->property = $matcher->matchField;
                    $foo->operator = "=";
                    $foo->value = $row[$matcher->importField];
src/PartKeepr/ImportBundle/Configuration/ManyToOneConfiguration.php on lines 141..149

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function treeMaker has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    treeMaker: function (node, model, prefix, callback, originalVisitedModels)

    Function _onItemKeyPress has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        _onItemKeyPress: function (view, record, item, index, e) {

      Function columnRenderer has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          columnRenderer: function (value, metadata, record, rowIndex, colIndex)

        Function getAssociatedStore has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            getAssociatedStore: function (inverseRecord, options, scope, records, isComplete) {

          Function rowkeydown has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                                  rowkeydown: function (grid, record, tr, rowIndex, e)

            Function callCollectionAction has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                callCollectionAction: function (action, method, parameters, callback, ignoreException)
            Severity: Minor
            Found in src/PartKeepr/FrontendBundle/Resources/public/js/Data/HydraProxy.js - About 35 mins to fix

              Function processCallActionResponse has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  processCallActionResponse: function (options, success, response, ignoreException, action)
              Severity: Minor
              Found in src/PartKeepr/FrontendBundle/Resources/public/js/Data/HydraProxy.js - About 35 mins to fix

                Function onBeforeDrop has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    onBeforeDrop: function (node, data, overModel, dropPosition, dropHandlers)

                  Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          DataProviderInterface $dataProvider,
                          IriConverter $iriConverter,
                          EntityManager $em,
                          AdvancedSearchFilter $advancedSearchFilter,
                          ReflectionService $reflectionService
                  Severity: Minor
                  Found in src/PartKeepr/BatchJobBundle/Action/ExecuteBatchJobAction.php - About 35 mins to fix

                    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            TokenStorage $tokenStorage,
                            EntityManager $entityManager,
                            UserManipulator $userManipulator,
                            UserManagerInterface $userManager,
                            $userLimit = false
                    Severity: Minor
                    Found in src/PartKeepr/AuthBundle/Services/UserService.php - About 35 mins to fix

                      Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              UploadedFileService $uploadedFileService,
                              ImageService $imageService,
                              Reader $reader,
                              PropertyAccessorInterface $propertyAccessor,
                              IriConverterInterface $iriConverter

                        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                UserService $userService,
                                UserManipulator $userManipulator,
                                EncoderFactory $encoderFactory,
                                UserManagerInterface $userManager,
                                ContainerInterface $container
                        Severity: Minor
                        Found in src/PartKeepr/AuthBundle/Action/ChangePasswordAction.php - About 35 mins to fix
                          Severity
                          Category
                          Status
                          Source
                          Language