Sign upLogin

pasosdeJesus/cor1440_gen

View on GitHub
Star

Showing 234 of 234 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                  vfid << f.id
                  aw = actividad.respuestafor.where(formulario_id: f.id)
                  if aw.count == 0
                    rf = Mr519Gen::Respuestafor.create(
                      formulario_id: f.id,
Severity: Major
Found in lib/cor1440_gen/concerns/controllers/actividades_controller.rb and 1 other location - About 1 hr to fix
lib/cor1440_gen/concerns/controllers/efectos_controller.rb on lines 72..92

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 65.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method actividadpf_ids= has 37 lines of code (exceeds 25 allowed). Consider refactoring.
Open

          def actividadpf_ids=(v)
            unless actividad
              puts "OJO SIN ACTIVIDAD_ID"
              return
            end
Severity: Minor
Found in lib/cor1440_gen/concerns/models/actividad_proyectofinanciero.rb - About 1 hr to fix

    Method poblacion_cor1440_gen has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

              def poblacion_cor1440_gen
            # En cuenta de poblacion no tiene en cuenta locales,
            # para coincidir con tipo de indicador que cuenta
            # usando tabla de población
            actividad_rangoedadac.inject(0) do |memo, r|
    Severity: Minor
    Found in lib/cor1440_gen/concerns/models/actividad.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method nueva_asistencia has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

              def nueva_asistencia
            authorize!(:new, Msip::Persona)
            if params[:actividad_id].nil?
              resp_error("Falta parámetro actividad_id")
              return
    Severity: Minor
    Found in lib/cor1440_gen/concerns/controllers/actividades_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method atributos_show has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

              def atributos_show
            [
              :id,
              :nombre,
              :titulo,
    Severity: Minor
    Found in lib/cor1440_gen/concerns/controllers/proyectosfinancieros_controller.rb - About 1 hr to fix

      Method recalcula_poblacion has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def recalcula_poblacion(actividad)
      rangoedad = {}
      Cor1440Gen::ActividadRangoedadac
        .where(actividad_id: actividad.id).delete_all
      actividad.asistencia.each do |asis|
      Severity: Minor
      Found in app/helpers/cor1440_gen/conteos_helper.rb - About 1 hr to fix

        Method filtra_contenido_params has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                  def filtra_contenido_params
            if !params || !params[:actividad]
              return
            end
        Severity: Minor
        Found in lib/cor1440_gen/concerns/controllers/actividades_controller.rb - About 1 hr to fix

          Method new has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                    def new
            if params[:mindicadorpf_id] && Cor1440Gen::Mindicadorpf.where(id: params[:mindicadorpf_id].to_i).count == 1
              mind = Cor1440Gen::Mindicadorpf.find(params[:mindicadorpf_id].to_i)
              fini = Date.today
              ffin = fini + 1.month
          Severity: Minor
          Found in lib/cor1440_gen/concerns/controllers/pmsindicadorpf_controller.rb - About 1 hr to fix

            Method asegura_camposdinamicos has 33 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                      def self.asegura_camposdinamicos(persona, current_usuario_id)
            if persona.respond_to?(:proyectofinanciero)
              persona.proyectofinanciero.each do |pf|
                pf.caracterizacion.each do |ca|
                  cp = Cor1440Gen::Caracterizacionpersona.where(
            Severity: Minor
            Found in lib/cor1440_gen/concerns/controllers/personas_controller.rb - About 1 hr to fix

              Method presenta has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
              Open

                        def presenta(atr)
            case atr.to_s
            when 'actividadpf'
              m = actividadpf_ids.map do |idapf|
                apf = Cor1440Gen::Actividadpf.find(idapf)
              Severity: Minor
              Found in lib/cor1440_gen/concerns/models/mindicadorpf.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method duracion has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                        def duracion
            prob = ""
            if params[:fechainicio] &&
                params[:fechacierre]
              fini = params[:fechainicio]
              Severity: Minor
              Found in lib/cor1440_gen/concerns/controllers/proyectosfinancieros_controller.rb - About 1 hr to fix

                Method new has 28 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                          def new
            if params[:proyectofinanciero_id]
              @indicadorpf = Indicadorpf.new
              @indicadorpf.proyectofinanciero_id = params[:proyectofinanciero_id]
              @indicadorpf.numero = "R"
                Severity: Minor
                Found in lib/cor1440_gen/concerns/controllers/indicadorespf_controller.rb - About 1 hr to fix

                  Method actividadpf_ids= has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                            def actividadpf_ids=(v)
            unless actividad
              puts "OJO SIN ACTIVIDAD_ID"
              return
            end
                  Severity: Minor
                  Found in lib/cor1440_gen/concerns/models/actividad_proyectofinanciero.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Method recalcula_poblacion has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def recalcula_poblacion(actividad)
      rangoedad = {}
      Cor1440Gen::ActividadRangoedadac
        .where(actividad_id: actividad.id).delete_all
      actividad.asistencia.each do |asis|
                  Severity: Minor
                  Found in app/helpers/cor1440_gen/conteos_helper.rb - About 1 hr to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                              if !params[:filtro] || !params[:filtro]["fechaini"] ||
                params[:filtro]["fechaini"] != ""
              @contarb_fechaini = if !params[:filtro] || !params[:filtro]["fechaini"]
                Msip::FormatoFechaHelper.inicio_semestre_ant
              else
                  Severity: Major
                  Found in lib/cor1440_gen/concerns/controllers/actividades_controller.rb and 3 other locations - About 1 hr to fix
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 693..703
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 705..715
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 829..841

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                              if !params[:filtro] || !params[:filtro]["fechafin"] ||
                params[:filtro]["fechafin"] != ""
              @contarb_fechafin = if !params[:filtro] || !params[:filtro]["fechafin"]
                Msip::FormatoFechaHelper.fin_semestre_ant
              else
                  Severity: Major
                  Found in lib/cor1440_gen/concerns/controllers/actividades_controller.rb and 3 other locations - About 1 hr to fix
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 693..703
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 705..715
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 815..827

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                              if !params[:filtro] || !params[:filtro]["fechaini"] ||
                params[:filtro]["fechaini"] != ""
              @fechaini = if !params[:filtro] || !params[:filtro]["fechaini"]
                Msip::FormatoFechaHelper.inicio_semestre_ant
              else
                  Severity: Major
                  Found in lib/cor1440_gen/concerns/controllers/actividades_controller.rb and 3 other locations - About 1 hr to fix
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 705..715
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 815..827
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 829..841

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                              if !params[:filtro] || !params[:filtro]["fechafin"] ||
                params[:filtro]["fechafin"] != ""
              @fechafin = if !params[:filtro] || !params[:filtro]["fechafin"]
                Msip::FormatoFechaHelper.fin_semestre_ant
              else
                  Severity: Major
                  Found in lib/cor1440_gen/concerns/controllers/actividades_controller.rb and 3 other locations - About 1 hr to fix
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 693..703
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 815..827
                  lib/cor1440_gen/concerns/controllers/actividades_controller.rb on lines 829..841

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 50.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Method gen_descfiltro has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                            def gen_descfiltro
            descfiltro = ""
            if filtrofechaini && !filtrofechafin
              descfiltro += "Después de " + filtrofechaini.to_s + ".  "
            end
                  Severity: Minor
                  Found in lib/cor1440_gen/concerns/models/informe.rb - About 1 hr to fix

                    Consider simplifying this complex logical expression.
                    Open

                                    elsif a && a[:id] && a[:id] == "" &&
                  a[:persona_attributes] &&
                  a[:persona_attributes][:id] &&
                  a[:persona_attributes][:id].to_i > 0 &&
                  Msip::Persona.where(
                    Severity: Major
                    Found in lib/cor1440_gen/concerns/controllers/actividades_controller.rb - About 1 hr to fix
                      Severity
                      Category
                      Status
                      Source
                      Language