Sign upLogin

pasosdeJesus/heb412_gen

View on GitHub
Star

Showing 73 of 73 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          def pintacampos
            @plantillahcr = Heb412Gen::Plantillahcr.new
            if params[:vista]
              vista = Msip::Ubicacion.connection.quote_string(
                params[:vista],
Severity: Major
Found in lib/heb412_gen/concerns/controllers/plantillahcr_controller.rb and 1 other location - About 1 hr to fix
lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb on lines 24..47

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 64.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method llena_plantilla_fd has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

          def self.llena_plantilla_fd(plantillahcr, fd)
            ruta = File.join(
              Rails.application.config.x.heb412_ruta,
              plantillahcr.ruta,
            ).to_s
Severity: Minor
Found in lib/heb412_gen/concerns/controllers/plantillahcr_controller.rb - About 1 hr to fix

    Method fichaimp has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def fichaimp
      establece_registro
      unless @registro
        return
      end
    Severity: Minor
    Found in app/controllers/heb412_gen/modelos_controller.rb - About 1 hr to fix

      Method llena_plantilla_multiple_fd has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

                def self.llena_plantilla_multiple_fd(plantillahcm, fd,
            nomcontrolador = nil)
            ruta = File.join(
              Rails.application.config.x.heb412_ruta,
              plantillahcm.ruta,
      Severity: Minor
      Found in lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      if File.exist?("#{nfuente}.xlsx")
                File.delete("#{nfuente}.xlsx")
              end
              dir = File.dirname(ndest)
              bn = File.basename(ndest)
        Severity: Major
        Found in lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb and 1 other location - About 1 hr to fix
        lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb on lines 240..248

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                      if File.exist?("#{nfuente}.pdf")
                File.delete("#{nfuente}.pdf")
              end
              dir = File.dirname(ndest)
              bn = File.basename(ndest)
        Severity: Major
        Found in lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb and 1 other location - About 1 hr to fix
        lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb on lines 251..259

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 53.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method update has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                  def update
            authorize!(:edit, Heb412Gen::Plantillahcr)
            @vista = @plantillahcr.vista
            respond_to do |format|
              if @plantillahcr.update(plantillahcr_params)
        Severity: Minor
        Found in lib/heb412_gen/concerns/controllers/plantillahcr_controller.rb - About 1 hr to fix

          Method perform has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              def perform(idplantilla, cmodelo, ccontrolador, ids, narch, parsimp,
      extension, campoid = :id, params = nil)
          Severity: Major
          Found in app/jobs/heb412_gen/generalistado_job.rb - About 1 hr to fix

            Method vista_listado has 9 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                def self.vista_listado(plant, ids, modelo, narch, parsimp, extension,
      campoid = :id, params = nil, controlador = nil)
            Severity: Major
            Found in app/controllers/heb412_gen/modelos_controller.rb - About 1 hr to fix

              Method programa_generacion_listado has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  def programa_generacion_listado(params, extension, campoid = :id)
      if params[:idplantilla].nil? or params[:idplantilla].to_i <= 0 or
          @registros == []
        flash[:error] = "No hay registros por generar"
      elsif Heb412Gen::Plantillahcm.where(
              Severity: Minor
              Found in app/controllers/heb412_gen/modelos_controller.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method convierte_a_extension_esperada has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                        def self.convierte_a_extension_esperada(nfuente, ndest, extension)
            if extension == ".ods"
              FileUtils.mv(nfuente, "#{ndest}#{extension}")
            elsif extension == ".pdf"
              if File.exist?("#{nfuente}.pdf")
              Severity: Minor
              Found in lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method pintacampos has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                        def pintacampos
            @plantillahcr = Heb412Gen::Plantillahcr.new
            if params[:vista]
              vista = Msip::Ubicacion.connection.quote_string(
                params[:vista],
              Severity: Minor
              Found in lib/heb412_gen/concerns/controllers/plantillahcr_controller.rb - About 1 hr to fix

                Method pintacampos has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                          def pintacampos
            @plantillahcm = Heb412Gen::Plantillahcm.new
            if params[:vista]
              vista = Msip::Ubicacion.connection.quote_string(
                params[:vista],
                Severity: Minor
                Found in lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb - About 1 hr to fix

                  Method fichapdf has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      def fichapdf
      establece_registro
      unless @registro
        return
      end
                  Severity: Minor
                  Found in app/controllers/heb412_gen/modelos_controller.rb - About 1 hr to fix

                    Method create_gen has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                              def create_gen(plantillahcr)
            respond_to do |format|
              if plantillahcr.save
                ordena_plantillahcr
                format.html do
                    Severity: Minor
                    Found in lib/heb412_gen/concerns/controllers/plantillahcr_controller.rb - About 1 hr to fix

                      Method perform has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          def perform(idplantilla, nomcontrolador, narchent, narcherr, extension, ulteditor_id)
      puts "Inicio de generación de plantilla #{idplantilla} con nomcontrolador #{nomcontrolador}, importando de #{narchent} escribiendo errores en #{narcherr} con extensión #{extension} ulteditor_id es #{ulteditor_id}"
      plant = Heb412Gen::Plantillahcm.find(idplantilla)
      controlador = nomcontrolador.constantize.new
      modelo = controlador.clase
                      Severity: Minor
                      Found in app/jobs/heb412_gen/importalistado_job.rb - About 1 hr to fix

                        Method create_gen has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                  def create_gen(plantillahcm)
            respond_to do |format|
              if plantillahcm.save
                ordena_plantillahcm
                format.html do
                        Severity: Minor
                        Found in lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb - About 1 hr to fix

                          Method cons_a_fd has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                          Open

                              def self.cons_a_fd(cons, colvista = [])
      l = []
      cons.each do |r|
        f = {}
        colvista.each do |c|
                          Severity: Minor
                          Found in app/controllers/heb412_gen/modelos_controller.rb - About 55 mins to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                    def create_gen(plantillahcr)
            respond_to do |format|
              if plantillahcr.save
                ordena_plantillahcr
                format.html do
                          Severity: Minor
                          Found in lib/heb412_gen/concerns/controllers/plantillahcr_controller.rb and 1 other location - About 55 mins to fix
                          lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb on lines 101..124

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 44.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                                    def create_gen(plantillahcm)
            respond_to do |format|
              if plantillahcm.save
                ordena_plantillahcm
                format.html do
                          Severity: Minor
                          Found in lib/heb412_gen/concerns/controllers/plantillahcm_controller.rb and 1 other location - About 55 mins to fix
                          lib/heb412_gen/concerns/controllers/plantillahcr_controller.rb on lines 98..121

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 44.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Severity
                          Category
                          Status
                          Source
                          Language