Showing 410 of 410 total issues
Method mapaosm
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def mapaosm
if !Rails.configuration.x.sivel2_consulta_web_publica
authorize! :index, Sivel2Gen::Caso
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method refresca_conscaso
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def refresca_conscaso
if ARGV.include?("db:migrate")
return 'Ejecutando migración'
end
if !ActiveRecord::Base.connection.data_source_exists? 'sivel2_gen_conscaso'
Function ejecutarAlCargarDocumentoYRecursos
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
static ejecutarAlCargarDocumentoYRecursos() {
console.log("* Corriendo Sivel2Gen__Motor::ejecutarAlCargarDocumentoYRecursos()")
if (typeof window.puntoMontaje == 'undefined') {
window.puntoMontaje = '/'
Function procesar_datos
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
procesar_datos(filas, variable) {
var dicEtiquetas = {}
filas.forEach(function(r) {
dicEtiquetas[r[variable]] = 0
if (typeof datosr[r.fecha] == 'undefined') {
Method atributos_show
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def atributos_show
[
# basicos
:id,
:fecha,
Method sivel2_gen_victima_presenta
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def sivel2_gen_victima_presenta(atr)
case atr.to_s
when 'fecha_caso'
self.caso ? self.caso.fecha : ''
when 'nombre'
Method remplazarfamiliar
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def remplazarfamiliar
@caso = Sivel2Gen::Caso.find(params[:caso_id])
@caso.current_usuario = current_usuario
@personados = Msip::Persona.find(params[:persona_id].to_i)
@vic_position = params[:vic_position].to_i
Method personas_procesa_filtros_sivel2_gen
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def personas_procesa_filtros_sivel2_gen(que1, tablas1, where1, que3,
tablas3, where3)
@filtrosegun.each do |e, r|
if (params[:filtro] && params[:filtro][r[:nomfiltro]] &&
params[:filtro][r[:nomfiltro]] != '')
Method nomrango
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.nomrango(fechaini, fechafin)
if !fechaini
return "Sin fechaini"
end
if !fechafin
Method pestanas_formulariocaso
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def pestanas_formulariocaso
#byebug
if current_usuario && can?(:solocambiaretiquetas, Sivel2Gen::Caso)
[
{ titulo: 'Etiquetas', parcial: 'etiquetas'},
Method remplazar
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
def remplazar
@grupoper = Msip::Grupoper.find(params[:grupoper_id].to_i)
@caso = Sivel2Gen::Caso.find(params[:caso_id].to_i)
@vicol_posicion = params[:vicol_posicion].to_i
@caso.current_usuario = current_usuario
Similar blocks of code found in 3 locations. Consider refactoring. Open
if(elem.type != "hidden" && elem.type != 'submit' &&
!elem.id.includes('personados') && !elem.classList.contains('chosen-search-input')){
elem.value = valores_input[indice_tipo_input]
elem.dispatchEvent(new Event('input'));
indice_tipo_input += 1;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
if(elem.type != "hidden" && elem.type != 'submit' &&
!elem.id.includes('personados') && !elem.classList.contains('chosen-search-input')){
valores_input.push(elem.value)
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 3 locations. Consider refactoring. Open
if(elem.type != "hidden" && elem.type != 'submit' &&
!elem.id.includes('personados') && !elem.id.includes('persona_trelacion1')){
console.log([elem.value, elem.type, elem.id])
if(elem.multiple){
let opciones = elem.options
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Function connect
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
connect() {
document.getElementById("capa-cargando").style.display = 'none';
console.log("Conexion de controlador enviar ficha caso establecida")
const pestanias = document.querySelectorAll('.fichacambia');
pestanias.forEach(function(pestania) {
Function actualizarGruposper
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
function actualizarGruposper(s) {
var sel = s.value;
var cadena = '';
var campo = document.querySelectorAll('#victimascolectivas .control-group[style!="display: none;"]');
campo.each(function(k, v) {
Method importa
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
def importa(datosent, datossal, menserror, opciones = {})
## Verifica que sí es un presunto responsable
pres = Sivel2Gen::Presponsable.
where('upper(nombre COLLATE es_co_utf_8)=upper(? COLLATE es_co_utf_8)', datosent['nombre_grupo'])
unless pres.empty?
Method sivel2_gen_destroy
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
def sivel2_gen_destroy
tcaso_id=@caso.id
if @caso.id
CasoUsuario.where(caso_id: @caso.id).destroy_all
end
Method genvic_tabla
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
def genvic_tabla(titulo, filas, tittotales, where1)
cuerpo = []
tot = 0;
filas.each do |f|
s = 0;
Method fuenteprensa_fecha_y_fuente_unicas
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def fuenteprensa_fecha_y_fuente_unicas
fuentesprensa = self.caso_fuenteprensa
valfp = []
fuentesprensa.each do |fp|
if fp && fp.fuenteprensa &&
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"