Showing 5 of 5 total issues
Method call has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
def call(env)
@app.call(env).on_complete do |response|
case response[:status].to_i
when 400
raise Passworks::Exceptions::BadRequest, error_400(response)Method error_body has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def error_body(response)
body = response[:body]
# body gets passed as a string, not sure if it is passed as something else from other spots?
if not body.nil? and not body.empty? and body.kind_of?(String)
body = ::JSON.parse(body)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def create(data={}, params={})
if collection_name.to_s == 'assets' && collection_uuid.nil?
raise Passworks::Exceptions::FileNotFound.new("Can't find file #{data[:file]}") unless data.has_key?(:file) && File.exists?(data[:file])
data[:file] = ::Faraday::UploadIO.new(data[:file], content_type_for(data[:file]))- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method each has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def each(&block)
next_page = nil
loop do
if next_page
response = client.get(collection_url, options.merge({query: {page: next_page}}))- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method resource_class has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
def resource_class
return Passworks::AssetResource if collection_name == 'assets'
# CertificateResource has no overrides, but follow along the normal flow.
return Passworks::CertificateResource if collection_name == 'certificates'
return Passworks::TemplateResource if collection_name == 'templates'- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"