patapizza/COP-Ruby

View on GitHub
phone/phone.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method hang_up has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def hang_up(*args)
    if args.size == 0
      raise Exception if self.active_call.nil?
      self.hang_up(@active_call)
    else
Severity: Minor
Found in phone/phone.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method answer has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def answer(*args)
    if args.size == 0
      next_call = @incoming_calls[0]
      raise Exception if next_call.nil?
      self.answer(next_call)
Severity: Minor
Found in phone/phone.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status