Sign upLogin

patternfly/angular-patternfly

View on GitHub
Star

Showing 300 of 300 total issues

Function controller has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  controller: function ($scope) {
    'use strict';
    var ctrl = this;

    var findWizard = function (scope) {
Severity: Minor
Found in src/wizard/wizard-review-page.component.js - About 1 hr to fix

    Function updateAll has 39 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        ctrl.updateAll = function () {
      // Need to deep watch changes in chart data
      prevChartData = angular.copy(ctrl.chartData);

      // Create an ID for the chart based on the chartId in the config if given
    Severity: Minor
    Found in src/charts/line/line-chart.component.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          this.in = function() {
      if (!this.isMax()) {
        this.level = (this.level * 10 + this.inc * 10) / 10;
      }
    };
      Severity: Major
      Found in src/canvas-view/canvas/canvas-viewmodel.js and 1 other location - About 1 hr to fix
      src/canvas-view/canvas/canvas-viewmodel.js on lines 1148..1152

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          this.out = function() {
      if (!this.isMin()) {
        this.level = (this.level * 10 - this.inc * 10) / 10;
      }
    };
      Severity: Major
      Found in src/canvas-view/canvas/canvas-viewmodel.js and 1 other location - About 1 hr to fix
      src/canvas-view/canvas/canvas-viewmodel.js on lines 1139..1143

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 66.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function loadIcons has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          ctrl.loadIcons = function () {
      var tmp = document.createElement('i');
      var char = '';
      var promises = [];
      var questionCode = ctrl.findIconUnicode('fa fa-question');
      Severity: Minor
      Found in src/charts/topology-map/topologyMap.component.js - About 1 hr to fix

        Function mouseDown has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                ctrl.mouseDown = function (evt) {
          if (ctrl.readOnly) {
            return;
          }
        Severity: Minor
        Found in src/canvas-view/canvas/canvas-component.js - About 1 hr to fix

          Function setUpTooltips has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              ctrl.setUpTooltips = function () {
      var canvas = d3.select(ctrl.canvas);
      if (ctrl.tooltipStyle) {
        ctrl.tooltipStyle = {
          size: ctrl.tooltipStyle.size || 12,
          Severity: Minor
          Found in src/charts/topology-map/topologyMap.component.js - About 1 hr to fix

            Function contents has 38 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    contents: function (d) {
          var tipRows;
          var percentUsed = 0;

          if (ctrl.config.tooltipFn) {
            Severity: Minor
            Found in src/charts/sparkline/sparkline-chart.component.js - About 1 hr to fix

              Function setPagination has 38 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  function setPagination () {
      if (angular.isUndefined(ctrl.dtOptions)) {
        ctrl.dtOptions = {};
      } else {
        // Switch dtOption pagination properties to new pagination schema
              Severity: Minor
              Found in src/table/tableview/table-view.component.js - About 1 hr to fix

                Function controller has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  controller: function ($element) {
    'use strict';

    var ctrl = this;
                Severity: Minor
                Found in src/form/form-group/form-group.component.js - About 1 hr to fix

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      var unselectAll = function () {
      //traverse steps array and set each "selected" property to false
      angular.forEach(ctrl.getEnabledSteps(), function (step) {
        step.selected = false;
      });
                  Severity: Major
                  Found in src/wizard/wizard.component.js and 1 other location - About 1 hr to fix
                  src/wizard/wizard-step.component.js on lines 69..76

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Identical blocks of code found in 2 locations. Consider refactoring.
                  Open

                      var unselectAll = function () {
      //traverse steps array and set each "selected" property to false
      angular.forEach(ctrl.getEnabledSteps(), function (step) {
        step.selected = false;
      });
                  Severity: Major
                  Found in src/wizard/wizard-step.component.js and 1 other location - About 1 hr to fix
                  src/wizard/wizard.component.js on lines 47..54

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 65.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function controller has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    controller: function () {
    'use strict';

    var ctrl = this;
                  Severity: Minor
                  Found in src/filters/simple-filter/filter-component.js - About 1 hr to fix

                    Function controller has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      controller: function ($timeout) {
    'use strict';
    var ctrl = this, prevChartData, prevLayout;

    ctrl.updateAll = function () {
                    Severity: Minor
                    Found in src/charts/utilization-bar/utilization-bar-chart.component.js - About 1 hr to fix

                      Function controller has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        controller: function ($scope) {
    'use strict';
    var ctrl = this;

    ctrl.$onInit = function () {
                      Severity: Minor
                      Found in src/modals/modal-overlay/modal-overlay.component.js - About 1 hr to fix

                        Function controller has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                          controller: function () {
    'use strict';

    var ctrl = this;
                        Severity: Minor
                        Found in src/filters/filter-panel/filter-panel-results-component.js - About 1 hr to fix

                          Function $onInit has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              ctrl.$onInit = function () {
      var findWizardStep = function (scope) {
        var wizardStep;

        if (scope) {
                          Severity: Minor
                          Found in src/wizard/wizard-substep.component.js - About 1 hr to fix

                            Function setUpSelection has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                ctrl.setUpSelection = function () {
      var canvas = d3.select(ctrl.canvas);
      canvas.on('click', click);
      function click () {
        var node;
                            Severity: Minor
                            Found in src/charts/topology-map/topologyMap.component.js - About 1 hr to fix

                              Function navigateToItem has 36 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  var navigateToItem = function (item) {
      var navItem = getFirstNavigateChild(item);
      var navTo;
      if (navItem) {
        ctrl.showMobileNav = false;
                              Severity: Minor
                              Found in src/navigation/vertical-navigation.component.js - About 1 hr to fix

                                Function controller has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                                Open

                                  controller: function () {
    'use strict';
    var ctrl = this;

    var heatmapColorPatternDefaults = ['#d4f0fa', '#F9D67A', '#EC7A08', '#CE0000'];
                                Severity: Minor
                                Found in src/charts/heatmap/heatmap-legend.component.js - About 1 hr to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language