Sign upLogin

pauldix/sax-machine

View on GitHub
Star

Showing 10 of 10 total issues

Method _end_element has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    def _end_element(name)
      name = normalize_name(name)

      start_tag = stack[-2]
      close_tag = stack[-1]
Severity: Minor
Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method data_class_value has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def data_class_value(data_class, value)
      case data_class.to_s
      when "String"  then value != NO_BUFFER ? value.to_s : value
      when "Integer" then value != NO_BUFFER ? value.to_i : value
      when "Float"   then value != NO_BUFFER ? value.to_s.gsub(",",".").to_f : value
Severity: Minor
Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _start_element has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def _start_element(name, attrs = [])
      name   = normalize_name(name)
      node   = stack.last
      object = node.object
Severity: Minor
Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _start_element has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def _start_element(name, attrs = [])
      name   = normalize_name(name)
      node   = stack.last
      object = node.object
Severity: Minor
Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 1 hr to fix

    Method _end_element has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def _end_element(name)
      name = normalize_name(name)

      start_tag = stack[-2]
      close_tag = stack[-1]
    Severity: Minor
    Found in lib/sax-machine/handlers/sax_abstract_handler.rb - About 1 hr to fix

      Method elements has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def elements(name, options = {}, &block)
      real_name = (options[:as] ||= name).to_s

      if options[:class]
        sax_config.add_collection_element(name, options)
      Severity: Minor
      Found in lib/sax-machine/sax_document.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method initialize has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def initialize(attributes = {})
      attributes.each do |name, value|
        send("#{name}=", value)
      end
      Severity: Minor
      Found in lib/sax-machine/sax_document.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method create_attr has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def create_attr(real_name, &block)
      attr_reader(real_name) unless method_defined?(real_name)

      if !method_defined?("#{real_name}=")
        if block_given?
      Severity: Minor
      Found in lib/sax-machine/sax_document.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def value(name, options = {}, &block)
      real_name = (options[:as] ||= name).to_s
      sax_config.add_top_level_element_value(self.class.to_s, options.merge(name: name))
      create_attr(real_name, &block)
      Severity: Minor
      Found in lib/sax-machine/sax_document.rb and 1 other location - About 15 mins to fix
      lib/sax-machine/sax_document.rb on lines 48..51

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          def attribute(name, options = {}, &block)
      real_name = (options[:as] ||= name).to_s
      sax_config.add_top_level_attribute(self.class.to_s, options.merge(name: name))
      create_attr(real_name, &block)
      Severity: Minor
      Found in lib/sax-machine/sax_document.rb and 1 other location - About 15 mins to fix
      lib/sax-machine/sax_document.rb on lines 54..57

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 25.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language