paulholden2/springcm-sdk

View on GitHub

Showing 25 of 25 total issues

Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def initialize(data, set_name, subject, group, client)
Severity: Minor
Found in lib/springcm-sdk/applied_attribute_set.rb - About 35 mins to fix

    Method attribute_group has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def attribute_group(name: nil, uid: nil)
          if (name.nil? && uid.nil?) || (!name.nil? && !uid.nil?)
            raise ArgumentError.new("Specify exactly one of: name, uid")
          end
          all_attribute_groups.select { |group|
    Severity: Minor
    Found in lib/springcm-sdk/account.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method method_missing has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def method_missing(m, *args, &block)
          mode = :get
          method = m.to_s
          if method.end_with?("=")
            mode = :set
    Severity: Minor
    Found in lib/springcm-sdk/object.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method connect has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def connect(safe=true)
          conn = Faraday.new(url: auth_url) do |conn|
            conn.request :retry, retry_statuses: [429], exceptions: [Springcm::RateLimitExceededError]
            conn.use Springcm::Middleware::RateLimit
            conn.use Springcm::Middleware::RetryConnectionFailed if @options[:retry_connection_failed]
    Severity: Minor
    Found in lib/springcm-sdk/client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method authorized_connection has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def authorized_connection(*options)
          if !authenticated?
            connect!
          end
    
    
    Severity: Minor
    Found in lib/springcm-sdk/client.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language