Sign upLogin

payolapayments/payola

View on GitHub
Star
app/services/payola/start_subscription.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def run
      begin
        subscription.verify_charge!

        customer = find_or_create_customer
Severity: Minor
Found in app/services/payola/start_subscription.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def run
      begin
        subscription.verify_charge!

        customer = find_or_create_customer
Severity: Minor
Found in app/services/payola/start_subscription.rb - About 1 hr to fix

    Method find_or_create_customer has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        def find_or_create_customer
      if subscription.stripe_customer_id.present?
        # If an existing Stripe customer id is specified, use it
        stripe_customer_id = subscription.stripe_customer_id
      elsif subscription.owner
    Severity: Minor
    Found in app/services/payola/start_subscription.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method find_or_create_customer has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def find_or_create_customer
      if subscription.stripe_customer_id.present?
        # If an existing Stripe customer id is specified, use it
        stripe_customer_id = subscription.stripe_customer_id
      elsif subscription.owner
    Severity: Minor
    Found in app/services/payola/start_subscription.rb - About 1 hr to fix

      There are no issues that match your filters.

      Category
      Status