Sign upLogin

payout/rester

View on GitHub
Star
lib/rester/service/middleware/error_handling.rb

Summary

Maintainability
A
55 mins
Test Coverage

Method _error_to_response has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

      def _error_to_response(error)
        code = _error_to_http_code(error)

        unless [401, 403, 404].include?(code)
          body_h = { error: _error_name(error) }
Severity: Minor
Found in lib/rester/service/middleware/error_handling.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid rescuing the Exception class. Perhaps you meant to rescue StandardError?
Open

          rescue Exception => error
            throw :error, error
Severity: Minor
Found in lib/rester/service/middleware/error_handling.rb by rubocop

This cop checks for rescue blocks targeting the Exception class.

Example:

# bad

begin
  do_something
rescue Exception
  handle_exception
end

Example:

# good

begin
  do_something
rescue ArgumentError
  handle_exception
end

There are no issues that match your filters.

Category
Status