Sign upLogin

paypay/paypayopa-sdk-php

View on GitHub
Star
src/Controllers/Payment.php

Summary

Maintainability
C
1 day
Test Coverage
A
96%

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function capturePaymentAuth($payload)
    {
        $this->payloadTypeCheck($payload, new CapturePaymentAuthPayload());
        $main = $this->MainInst;
        $data = $payload->serialize();
Severity: Major
Found in src/Controllers/Payment.php and 1 other location - About 3 hrs to fix
src/Controllers/Payment.php on lines 202..213

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function revertAuth($payload)
    {
        $this->payloadTypeCheck($payload, new RevertAuthPayload());
        $main = $this->MainInst;
        $data = $payload->serialize();
Severity: Major
Found in src/Controllers/Payment.php and 1 other location - About 3 hrs to fix
src/Controllers/Payment.php on lines 178..189

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 160.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function getPaymentDetails($merchantPaymentId, $paymentType = 'web_cashier')
    {
        $endpoint = $this->endpointByPaymentType($paymentType, $merchantPaymentId)['endpoint'];
        $url = $this->endpointByPaymentType($paymentType, $merchantPaymentId)['url'];
        $options = $this->HmacCallOpts('GET', $endpoint);
Severity: Minor
Found in src/Controllers/Payment.php and 1 other location - About 45 mins to fix
src/Controllers/Payment.php on lines 134..140

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function cancelPayment($merchantPaymentId, $paymentType = 'web_cashier')
    {
        $endpoint = $this->endpointByPaymentType($paymentType, $merchantPaymentId)['endpoint'];
        $url = $this->endpointByPaymentType($paymentType, $merchantPaymentId)['url'];
        $options = $this->HmacCallOpts('DELETE', $endpoint);
Severity: Minor
Found in src/Controllers/Payment.php and 1 other location - About 45 mins to fix
src/Controllers/Payment.php on lines 114..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 95.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status