Sign upLogin

pazz/alot

View on GitHub
Star
alot/db/envelope.py

Summary

Maintainability
C
1 day
Test Coverage

Function construct_mail has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def construct_mail(self):
        """
        Compiles the information contained in this envelope into a
        :class:`email.Message`.
        """
Severity: Minor
Found in alot/db/envelope.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File envelope.py has 293 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# Copyright (C) 2011-2012  Patrick Totzke <patricktotzke@gmail.com>
# This file is released under the GNU GPL, version 3 or a later revision.
# For further details see the COPYING file
import glob
import logging
Severity: Minor
Found in alot/db/envelope.py - About 3 hrs to fix

    Function parse_template has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        def parse_template(self, raw, reset=False, only_body=False,
                       target_body='plaintext'):
        """Parse a template or user edited string to fills this envelope.

        :param raw: the string to parse.
    Severity: Minor
    Found in alot/db/envelope.py - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __init__ has 11 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(
    Severity: Major
    Found in alot/db/envelope.py - About 1 hr to fix

      TODO found
      Open

              # TODO: if this was as collections.defaultdict a number of methods
      Severity: Minor
      Found in alot/db/envelope.py by fixme

      There are no issues that match your filters.

      Category
      Status