Sign upLogin

pboling/celluloid-io-pg-listener

View on GitHub
Star
lib/celluloid-io-pg-listener/supervise_signature.rb

Summary

Maintainability
A
0 mins
Test Coverage

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      args.is_a?(Hash) && !args["database_url"].nil?
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      connection_info["user"]     = uri.user
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use empty lines between method definitions.
Open

    def has_database_url?(args)
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
Open

          type: type,
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

This cops checks the indentation of the first key in a hash literal where the opening brace and the first key are on separate lines. The other keys' indentations are handled by the AlignHash cop.

By default, Hash literals that are arguments in a method call with parentheses, and where the opening curly brace of the hash is on the same line as the opening parenthesis of the method call, shall have their first key indented one step (two spaces) more than the position inside the opening parenthesis.

Other hash literals shall have their first key indented one step more than the start of the line where the opening curly brace is.

This default style is called 'specialinsideparentheses'. Alternative styles are 'consistent' and 'align_braces'. Here are examples:

Example: EnforcedStyle: specialinsideparentheses (default)

# The `special_inside_parentheses` style enforces that the first key
# in a hash literal where the opening brace and the first key are on
# separate lines is indented one step (two spaces) more than the
# position inside the opening parentheses.

# bad
hash = {
  key: :value
}
and_in_a_method_call({
  no: :difference
                     })

# good
special_inside_parentheses
hash = {
  key: :value
}
but_in_a_method_call({
                       its_like: :this
                     })

Example: EnforcedStyle: consistent

# The `consistent` style enforces that the first key in a hash
# literal where the opening brace and the first key are on
# seprate lines is indented the same as a hash literal which is not
# defined inside a method call.

# bad
hash = {
  key: :value
}
but_in_a_method_call({
                       its_like: :this
                      })

# good
hash = {
  key: :value
}
and_in_a_method_call({
  no: :difference
})

Example: EnforcedStyle: align_braces

# The `align_brackets` style enforces that the opening and closing
# braces are indented to the same position.

# bad
and_now_for_something = {
                          completely: :different
}

# good
and_now_for_something = {
                          completely: :different
                        }

Rename has_database_url? to database_url?.
Open

    def has_database_url?(args)
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

This cop makes sure that predicates are named properly.

Example:

# bad
def is_even?(value)
end

# good
def even?(value)
end

# bad
def has_value?
end

# good
def value?
end

Use each_with_object instead of inject.
Open

      args.inject({}) do |memo, (key, value)|
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

This cop looks for inject / reduce calls where the passed in object is returned at the end and so could be replaced by eachwithobject without the need to return the object at the end.

However, we can't replace with eachwithobject if the accumulator parameter is assigned to within the block.

Example:

# bad
[1, 2].inject({}) { |a, e| a[e] = e; a }

# good
[1, 2].each_with_object({}) { |e, a| a[e] = e }

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      connection_info["password"] = uri.password
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      connection_info["host"]     = uri.host
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [86/80]
Open

    # returns a hash of connection info extracted from the database url (as on Heroku)
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      connection_info["port"]     = uri.port
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use the return of the conditional for variable assignment and comparison.
Open

      if KEYS_WITH_SYMBOL_VALUES.include?(key)
        hash[key.to_sym] = value.to_sym
      else
        hash[key.to_sym] = value
      end
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      connection_info["dbname"]   = (uri.path || "").split("/")[1]
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Freeze mutable objects assigned to constants.
Open

    KEYS_WITH_SYMBOL_VALUES = %( callback_method )
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

This cop checks whether some constant value isn't a mutable literal (e.g. array or hash).

Example:

# bad
CONST = [1, 2, 3]

# good
CONST = [1, 2, 3].freeze

Line is too long. [86/80]
Open

        args.merge!(convert_database_url_to_hash(db_url: args.delete("database_url")))
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      connection_info["dbname"]   = (uri.path || "").split("/")[1]
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use empty lines between method definitions.
Open

    def symbolize_keys(args)
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Line is too long. [81/80]
Open

  #           redis_url: <%= ENV["REDISTOGO_URL"] || "redis://localhost:6379/" %>
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

        args.merge!(convert_database_url_to_hash(db_url: args.delete("database_url")))
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

      connection_info["dbname"]   = (uri.path || "").split("/")[1]
Severity: Minor
Found in lib/celluloid-io-pg-listener/supervise_signature.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

There are no issues that match your filters.

Category
Status