Sign upLogin

pboling/js-cookie-calibre

View on GitHub
Star

Showing 9 of 9 total issues

Function exports has 224 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function (grunt) {

    function encodingMiddleware(request, response, next) {
        var url = require('url').parse(request.url, true, true);
        var query = url.query;
Severity: Major
Found in Gruntfile.js - About 1 day to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (arguments.length === 0) {
                var result = {};
                var cookiesInstance = cookies();
                Object.keys(cookiesInstance.get()).forEach(function (cookieKey) {
                    if (cookieKey.search('calibre_') === 0) {
    Severity: Major
    Found in src/js.cookie.calibre.js and 1 other location - About 3 hrs to fix
    src/js.cookie.calibre.js on lines 66..77

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                if (arguments.length === 0) {
                var result = {};
                var cookiesInstance = cookies();
                Object.keys(cookiesInstance.get()).forEach(function (cookieKey) {
                    if (cookieKey.search('calibre_') === 0) {
    Severity: Major
    Found in src/js.cookie.calibre.js and 1 other location - About 3 hrs to fix
    src/js.cookie.calibre.js on lines 45..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 104.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function browsers has 80 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                        browsers: (function () {
                        var browsers = {
                            'iOS': [{
                                browserName: 'iphone',
                                platform: 'OS X 10.10',
    Severity: Major
    Found in Gruntfile.js - About 3 hrs to fix

      Function init has 52 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function init (converter) {
        // represent the cookies from js.cookie with a converter if one was supplied
        var cookies = function () {
            return window.Cookies.withConverter(converter);
        };
      Severity: Major
      Found in src/js.cookie.calibre.js - About 2 hrs to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                                    'windowsXP': [{
                                browserName: 'internet explorer',
                                platform: 'Windows XP',
                                version: '8.0'
                            }, {
        Severity: Major
        Found in Gruntfile.js and 2 other locations - About 1 hr to fix
        Gruntfile.js on lines 163..175
        Gruntfile.js on lines 206..218

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                                    'mac': [{
                                browserName: 'safari',
                                platform: 'OS X 10.10',
                                version: '8.0'
                            }, {
        Severity: Major
        Found in Gruntfile.js and 2 other locations - About 1 hr to fix
        Gruntfile.js on lines 193..205
        Gruntfile.js on lines 206..218

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                                    'linux': [{
                                browserName: 'opera',
                                platform: 'Linux',
                                version: '12.15'
                            }, {
        Severity: Major
        Found in Gruntfile.js and 2 other locations - About 1 hr to fix
        Gruntfile.js on lines 163..175
        Gruntfile.js on lines 193..205

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 57.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function exports has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        module.exports = function (grunt) {

    function encodingMiddleware(request, response, next) {
        var url = require('url').parse(request.url, true, true);
        var query = url.query;
        Severity: Minor
        Found in Gruntfile.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language