Sign upLogin

pboling/require_bench

View on GitHub
Star

Showing 7 of 7 total issues

Method consume_with_timing has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    def consume_with_timing(type, file, *args)
      $require_bench_semaphore = true
      short_type = type[0]
      ret = nil
      # Not sure if this is actually a useful abstraction...
Severity: Minor
Found in lib/require_bench.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _require_bench_consume_file has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    def _require_bench_consume_file(type, file, *args)
      file_path = file.to_s
      # byebug if file_path.match?(/no_group_fox/)

      # Global $ variable, which is always truthy while inside the hack, is to
Severity: Minor
Found in lib/require_bench.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method consume_with_timing has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def consume_with_timing(type, file, *args)
      $require_bench_semaphore = true
      short_type = type[0]
      ret = nil
      # Not sure if this is actually a useful abstraction...
Severity: Minor
Found in lib/require_bench.rb - About 1 hr to fix

    Method _require_bench_file has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def _require_bench_file(type, measure, skippy, file_path, *args)
    Severity: Minor
    Found in lib/require_bench.rb - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if no_group && !no_group.empty?
      no_group_pattern = case no_group
                         when /,/
                           Regexp.union(*no_group.split(','))
                         when /\|/
      Severity: Minor
      Found in lib/require_bench.rb and 1 other location - About 35 mins to fix
      lib/require_bench.rb on lines 51..61

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          if skips && !skips.empty?
      skip_pattern = case skips
                     when /,/
                       Regexp.union(*skips.split(','))
                     when /\|/
      Severity: Minor
      Found in lib/require_bench.rb and 1 other location - About 35 mins to fix
      lib/require_bench.rb on lines 75..85

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method _require_bench_file has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def _require_bench_file(type, measure, skippy, file_path, *args)
      if !measure && skippy
        send("#{type}_without_timing", file_path, *args)
      elsif RequireBench::INCLUDE_PATTERN.nil? || measure
        RequireBench.consume_with_timing(type, file_path, *args)
      Severity: Minor
      Found in lib/require_bench.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language