Sign upLogin

pboling/shiftable

View on GitHub
Star

Showing 3 of 35 total issues

Class ModSignature has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

  class ModSignature
    VALID_ASSOCIATIONS = { sg: %i[belongs_to has_one], cx: %i[belongs_to has_many], pcx: %i[belongs_to has_many] }.freeze
    VALID_TYPES = VALID_ASSOCIATIONS.keys.dup.freeze
    DEFAULT_BEFORE_SHIFT = ->(*_) { true }
    attr_reader :associations, :options, :type, :base
Severity: Minor
Found in lib/shiftable/mod_signature.rb - About 2 hrs to fix

Method do_saves has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def do_saves
      if shift_each_wrapper
        each do |rec|
          shift_each_wrapper.call(self, rec) do
            bang ? rec.save! : rec.save
Severity: Minor
Found in lib/shiftable/shifting.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method do_save has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def do_save
      if shift_each_wrapper
        shift_each_wrapper.call(self, result) do
          bang ? result.save! : result.save
        end
Severity: Minor
Found in lib/shiftable/shifting_record.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language