pedroMMM/goss

View on GitHub
cmd/goss/goss.go

Summary

Maintainability
D
1 day
Test Coverage

Function main has 321 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func main() {
    startTime := time.Now()
    app := cli.NewApp()
    app.EnableBashCompletion = true
    app.Version = version
Severity: Major
Found in cmd/goss/goss.go - About 1 day to fix

    Function main has 20 return statements (exceeds 4 allowed).
    Open

    func main() {
        startTime := time.Now()
        app := cli.NewApp()
        app.EnableBashCompletion = true
        app.Version = version
    Severity: Major
    Found in cmd/goss/goss.go - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      {
                          Name:  "command",
                          Usage: "add new command",
                          Flags: []cli.Flag{
                              cli.DurationFlag{
      Severity: Minor
      Found in cmd/goss/goss.go and 1 other location - About 45 mins to fix
      cmd/goss/goss.go on lines 240..252

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      {
                          Name:  "addr",
                          Usage: "add new remote address:port - ex: google.com:80",
                          Flags: []cli.Flag{
                              cli.DurationFlag{
      Severity: Minor
      Found in cmd/goss/goss.go and 1 other location - About 45 mins to fix
      cmd/goss/goss.go on lines 281..293

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 114.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status