Method MatchingMap.UnmarshalJSON has 7 return statements (exceeds 4 allowed). Open
func (ret *MatchingMap) UnmarshalJSON(data []byte) error {
// Curried json.Unmarshal
unmarshal := func(i interface{}) error {
if err := json.Unmarshal(data, i); err != nil {
return errMethod MatchingMap.UnmarshalYAML has 5 return statements (exceeds 4 allowed). Open
func (ret *MatchingMap) UnmarshalYAML(unmarshal func(v interface{}) error) error {
// Validate configuration
zero := Matching{}
whitelist, err := util.WhitelistAttrs(zero, util.YAML)
if err != nil {Similar blocks of code found in 2 locations. Consider refactoring. Open
func (ret *MatchingMap) UnmarshalJSON(data []byte) error {
// Curried json.Unmarshal
unmarshal := func(i interface{}) error {
if err := json.Unmarshal(data, i); err != nil {
return err- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 290.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
func (ret *MatchingMap) UnmarshalYAML(unmarshal func(v interface{}) error) error {
// Validate configuration
zero := Matching{}
whitelist, err := util.WhitelistAttrs(zero, util.YAML)
if err != nil {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 247.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
struct field Id should be ID Open
Id string `json:"-" yaml:"-"`- Exclude checks
exported type Matching should have comment or be unexported Open
type Matching struct {- Exclude checks
exported method Matching.GetMeta should have comment or be unexported Open
func (r *Matching) GetMeta() meta { return r.Meta }- Exclude checks
exported method Matching.SetID should have comment or be unexported Open
func (a *Matching) SetID(id string) { a.Id = id }- Exclude checks
comment on exported method Matching.GetTitle should be of the form "GetTitle ..." Open
// FIXME: Can this be refactored?- Exclude checks
exported method Matching.ID should have comment or be unexported Open
func (a *Matching) ID() string { return a.Id }- Exclude checks
exported method MatchingMap.UnmarshalYAML should have comment or be unexported Open
func (ret *MatchingMap) UnmarshalYAML(unmarshal func(v interface{}) error) error {- Exclude checks
exported method Matching.Validate should have comment or be unexported Open
func (a *Matching) Validate(sys *system.System) []TestResult {- Exclude checks
exported type MatchingMap should have comment or be unexported Open
type MatchingMap map[string]*Matching- Exclude checks
receiver name r should be consistent with previous receiver name a for Matching Open
func (r *Matching) GetMeta() meta { return r.Meta }- Exclude checks
exported method MatchingMap.UnmarshalJSON should have comment or be unexported Open
func (ret *MatchingMap) UnmarshalJSON(data []byte) error {- Exclude checks
receiver name r should be consistent with previous receiver name a for Matching Open
func (r *Matching) GetTitle() string { return r.Title }- Exclude checks