Sign upLogin

pedroMMM/goss

View on GitHub
Star
resource/resource_list_genny.go

Summary

Maintainability
C
7 hrs
Test Coverage

Method ResourceTypeMap.UnmarshalJSON has 7 return statements (exceeds 4 allowed).
Open

func (ret *ResourceTypeMap) UnmarshalJSON(data []byte) error {
    // Curried json.Unmarshal
    unmarshal := func(i interface{}) error {
        if err := json.Unmarshal(data, i); err != nil {
            return err
Severity: Major
Found in resource/resource_list_genny.go - About 45 mins to fix

    Method ResourceTypeMap.UnmarshalYAML has 5 return statements (exceeds 4 allowed).
    Open

    func (ret *ResourceTypeMap) UnmarshalYAML(unmarshal func(v interface{}) error) error {
    // Validate configuration
    zero := ResourceType{}
    whitelist, err := util.WhitelistAttrs(zero, util.YAML)
    if err != nil {
    Severity: Major
    Found in resource/resource_list_genny.go - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (ret *ResourceTypeMap) UnmarshalJSON(data []byte) error {
    // Curried json.Unmarshal
    unmarshal := func(i interface{}) error {
        if err := json.Unmarshal(data, i); err != nil {
            return err
      Severity: Major
      Found in resource/resource_list_genny.go and 1 other location - About 3 hrs to fix
      resource/matching.go on lines 43..78

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 290.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

      func (ret *ResourceTypeMap) UnmarshalYAML(unmarshal func(v interface{}) error) error {
    // Validate configuration
    zero := ResourceType{}
    whitelist, err := util.WhitelistAttrs(zero, util.YAML)
    if err != nil {
      Severity: Major
      Found in resource/resource_list_genny.go and 1 other location - About 2 hrs to fix
      resource/matching.go on lines 80..107

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 247.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Your code does not pass gofmt in 1 place. Go fmt your code!
      Open

      // +build genny
      Severity: Minor
      Found in resource/resource_list_genny.go by gofmt

      exported method ResourceTypeMap.AppendSysResourceIfExists should have comment or be unexported
      Open

      func (r ResourceTypeMap) AppendSysResourceIfExists(sr string, sys *system.System) (*ResourceType, system.ResourceType, bool) {
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      receiver name ret should be consistent with previous receiver name r for ResourceTypeMap
      Open

      func (ret *ResourceTypeMap) UnmarshalYAML(unmarshal func(v interface{}) error) error {
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      type name will be used as resource.ResourceType by other packages, and that stutters; consider calling this Type
      Open

      type ResourceType generic.Type
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      don't use underscores in Go names; var old_res should be oldRes
      Open

          if old_res, ok := r[res.ID()]; ok {
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      receiver name ret should be consistent with previous receiver name r for ResourceTypeMap
      Open

      func (ret *ResourceTypeMap) UnmarshalJSON(data []byte) error {
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      exported type ResourceType should have comment or be unexported
      Open

      type ResourceType generic.Type
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      exported method ResourceTypeMap.UnmarshalYAML should have comment or be unexported
      Open

      func (ret *ResourceTypeMap) UnmarshalYAML(unmarshal func(v interface{}) error) error {
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      don't use underscores in Go names; var old_res should be oldRes
      Open

          if old_res, ok := r[res.ID()]; ok {
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      exported method ResourceTypeMap.AppendSysResource should have comment or be unexported
      Open

      func (r ResourceTypeMap) AppendSysResource(sr string, sys *system.System, config util.Config) (*ResourceType, error) {
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      exported type ResourceTypeMap should have comment or be unexported
      Open

      type ResourceTypeMap map[string]*ResourceType
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      exported method ResourceTypeMap.UnmarshalJSON should have comment or be unexported
      Open

      func (ret *ResourceTypeMap) UnmarshalJSON(data []byte) error {
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      type name will be used as resource.ResourceTypeMap by other packages, and that stutters; consider calling this TypeMap
      Open

      type ResourceTypeMap map[string]*ResourceType
      Severity: Minor
      Found in resource/resource_list_genny.go by golint

      There are no issues that match your filters.

      Category
      Status